Sign upLogin

gielfeldt/iterators

View on GitHub
Star
src/Iterator.php

Summary

Maintainability
A
0 mins
Test Coverage

The class Iterator has 11 public methods. Consider refactoring Iterator to keep number of public methods under 10.
Open

class Iterator
{
    public static function instanceOf($iterator, $class)
    {
        if ($iterator instanceof $class) {
Severity: Minor
Found in src/Iterator.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Missing class import via use statement (line '35', column '25').
Open

        $iterator = new \IteratorIterator($iterator);
Severity: Minor
Found in src/Iterator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid unused parameters such as '$key'.
Open

            function ($carry, $value, $key) {
Severity: Minor
Found in src/Iterator.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

There are no issues that match your filters.

Category
Status