gielfeldt/iterators

View on GitHub
src/ShuffleIterator.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '14', column '33').
Open

        parent::__construct(new \ArrayIterator());
Severity: Minor
Found in src/ShuffleIterator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '19', column '33').
Open

        $shuffledIterator = new \ArrayIterator();
Severity: Minor
Found in src/ShuffleIterator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid unused parameters such as '$iterator'.
Wontfix

    protected function generateElement($key, $value, $iterator)
Severity: Minor
Found in src/ShuffleIterator.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

There are no issues that match your filters.

Category
Status