gielfeldt/transactionalphp

View on GitHub

Showing 2 of 2 total issues

The class Connection has 11 public methods. Consider refactoring Connection to keep number of public methods under 10.
Open

class Connection
{
    /**
     * Operations buffer.
     *
Severity: Minor
Found in src/Connection.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Missing class import via use statement (line '90', column '23').
Open

            throw new \RuntimeException('Trying to commit nonexistent transaction.');
Severity: Minor
Found in src/Connection.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Severity
Category
Status
Source
Language