gilbarbara/styled-minimal

View on GitHub

Showing 9 of 11 total issues

Function formPseudo has 71 lines of code (exceeds 50 allowed). Consider refactoring.
Open

export const formPseudo = (props: Object): string => {
  const {
    bg,
    borderColor: bc,
    bordered,
Severity: Major
Found in src/utils/system.js - About 1 hr to fix

    Function select has 65 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    const select = props => {
      const {
        bg,
        bordered,
        borderColor: bc,
    Severity: Major
    Found in src/Select.jsx - About 1 hr to fix

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

        if (valid) {
          currentBorderColor = validation.valid;
        } else if (valid === false) {
          currentBorderColor = validation.invalid;
        }
      Severity: Major
      Found in src/utils/system.js and 3 other locations - About 1 hr to fix
      src/Input.jsx on lines 43..47
      src/Select.jsx on lines 43..47
      src/Textarea.jsx on lines 38..42

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 41.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

        if (valid) {
          currentBorderColor = validation.valid;
        } else if (valid === false) {
          currentBorderColor = validation.invalid;
        }
      Severity: Major
      Found in src/Select.jsx and 3 other locations - About 1 hr to fix
      src/Input.jsx on lines 43..47
      src/Textarea.jsx on lines 38..42
      src/utils/system.js on lines 137..141

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 41.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function styles has 54 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      const styles = props => {
        const {
          bg,
          bordered,
          borderColor: bc,
      Severity: Major
      Found in src/Input.jsx - About 1 hr to fix

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

            border: ${bordered ? `${px(bw || borderWidth)} solid ${currentBorderColor}` : 0};
        Severity: Major
        Found in src/Textarea.jsx and 2 other locations - About 55 mins to fix
        src/Input.jsx on lines 51..51
        src/Select.jsx on lines 53..53

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

            border: ${bordered ? `${px(bw || borderWidth)} solid ${currentBorderColor}` : 0};
        Severity: Major
        Found in src/Input.jsx and 2 other locations - About 55 mins to fix
        src/Select.jsx on lines 53..53
        src/Textarea.jsx on lines 46..46

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

            border: ${bordered ? `${px(bw || borderWidth)} solid ${currentBorderColor}` : 0};
        Severity: Major
        Found in src/Select.jsx and 2 other locations - About 55 mins to fix
        src/Input.jsx on lines 51..51
        src/Textarea.jsx on lines 46..46

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function styles has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
        Open

        const styles = props => {
          const { ml, mr, pb, pl, pr, pt } = props;
          const container = getTheme(props, 'container');
        
          const vertical = ({ verticalPadding }) => {
        Severity: Minor
        Found in src/Container.jsx - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language