Sign upLogin

ginpei/potoshop

View on GitHub
Star
src/pages/paint/PaintPage.tsx

Summary

Maintainability
C
1 day
Test Coverage

File PaintPage.tsx has 302 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// import * as firebase from 'firebase';
import { Color } from 'csstype';
import * as React from 'react';
import { connect } from 'react-redux';
import BubbleButton from '../../components/BubbleButton';
Severity: Minor
Found in src/pages/paint/PaintPage.tsx - About 3 hrs to fix

    PaintPage has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class PaintPage extends React.Component<IPaintPagePros, IPaintPageState> {
  protected currentUser: firebase.User | null = null;
  protected elCanvas: HTMLCanvasElement | null = null;
  protected storageRef = firebase.storage().ref('v1-images');
  protected canvasType = '';
    Severity: Minor
    Found in src/pages/paint/PaintPage.tsx - About 2 hrs to fix

      Function render has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public render () {
    return (
      <div className="PaintPage">
        {!this.state.imageLoading && <PaintCanvas
          height={this.state.height}
      Severity: Minor
      Found in src/pages/paint/PaintPage.tsx - About 1 hr to fix

        Function setUpSizes has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          protected setUpSizes () {
    // this is called only from `componentWillMount()`

    const el = document.documentElement!;
    const screenHeight = el.clientHeight;
        Severity: Minor
        Found in src/pages/paint/PaintPage.tsx - About 1 hr to fix

          Function constructor has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            constructor (props: IPaintPagePros) {
    super(props);
    this.state = {
      dirty: false,
      height: 0,
          Severity: Minor
          Found in src/pages/paint/PaintPage.tsx - About 1 hr to fix

            Function setUpSizes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              protected setUpSizes () {
    // this is called only from `componentWillMount()`

    const el = document.documentElement!;
    const screenHeight = el.clientHeight;
            Severity: Minor
            Found in src/pages/paint/PaintPage.tsx - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                this.setState({
      imageLoading: false,
      imageSize: {
        height: image.naturalHeight,
        width: image.naturalWidth,
            Severity: Minor
            Found in src/pages/paint/PaintPage.tsx and 1 other location - About 35 mins to fix
            src/pages/paint/PaintPage.tsx on lines 297..304

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  this.setState({
        imageLoading: false,
        imageSize: {
          height: image.naturalHeight,
          width: image.naturalWidth,
            Severity: Minor
            Found in src/pages/paint/PaintPage.tsx and 1 other location - About 35 mins to fix
            src/pages/paint/PaintPage.tsx on lines 318..325

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status