Sign upLogin

ginpei/potoshop

View on GitHub
Star
src/services/imageUtil.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Function getOrientation has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function getOrientation (file: File): Promise<ExifOrientation> {
  // TODO check why this is called twice

  const jpeg = 0xffd8;
  const exifMarker = 0xffe1;
Severity: Major
Found in src/services/imageUtil.ts - About 3 hrs to fix

    Function applyImageOrientation has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function applyImageOrientation (image: HTMLImageElement, orientation: ExifOrientation): Promise<HTMLImageElement> {
  const width = image.naturalWidth;
  const height = image.naturalHeight;

  const canvas = document.createElement('canvas');
    Severity: Minor
    Found in src/services/imageUtil.ts - About 1 hr to fix

      Function getOrientation has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      export async function getOrientation (file: File): Promise<ExifOrientation> {
  // TODO check why this is called twice

  const jpeg = 0xffd8;
  const exifMarker = 0xffe1;
      Severity: Minor
      Found in src/services/imageUtil.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function applyImageOrientation has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      function applyImageOrientation (image: HTMLImageElement, orientation: ExifOrientation): Promise<HTMLImageElement> {
  const width = image.naturalWidth;
  const height = image.naturalHeight;

  const canvas = document.createElement('canvas');
      Severity: Minor
      Found in src/services/imageUtil.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status