Sign upLogin

giovannelli/cassandra_object

View on GitHub
Star

Showing 37 of 37 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

module CassandraObject
  class Schema

    class << self
      DEFAULT_CREATE_KEYSPACE = {
Severity: Major
Found in lib/cassandra_object/schema.rb and 1 other location - About 5 hrs to fix
lib/cassandra_object/schemaless.rb on lines 3..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 174.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

module CassandraObject
  class Schemaless

    class << self
      DEFAULT_CREATE_KEYSPACE = {
Severity: Major
Found in lib/cassandra_object/schemaless.rb and 1 other location - About 5 hrs to fix
lib/cassandra_object/schema.rb on lines 3..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 174.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method select_records has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    def select_records(auto_paginate = true)
      results = []
      records = {}
      new_next_cursor = nil
Severity: Minor
Found in lib/cassandra_object/scope.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      def cassandra_cluster_options
        cluster_options = config.slice(*[
            :auth_provider,
            :client_cert,
            :compression,
Severity: Major
Found in lib/cassandra_object/adapters/cassandra_schemaless_adapter.rb and 1 other location - About 3 hrs to fix
lib/cassandra_object/adapters/cassandra_adapter.rb on lines 56..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 135.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      def cassandra_cluster_options
        cluster_options = config.slice(*[
            :auth_provider,
            :client_cert,
            :compression,
Severity: Major
Found in lib/cassandra_object/adapters/cassandra_adapter.rb and 1 other location - About 3 hrs to fix
lib/cassandra_object/adapters/cassandra_schemaless_adapter.rb on lines 68..128

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 135.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File cassandra_schemaless_adapter.rb has 300 lines of code (exceeds 250 allowed). Consider refactoring.
Open

gem 'cassandra-driver'
require 'cassandra'
require 'logger'

module CassandraObject
Severity: Minor
Found in lib/cassandra_object/adapters/cassandra_schemaless_adapter.rb - About 3 hrs to fix

    Method guess_type has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def self.guess_type(object)

        if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.4.0')
          case object
            when ::String then
    Severity: Major
    Found in lib/cassandra_object/types/type_helper.rb - About 2 hrs to fix

      File cassandra_adapter.rb has 265 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      gem 'cassandra-driver'
require 'cassandra'
require 'logger'

module CassandraObject
      Severity: Minor
      Found in lib/cassandra_object/adapters/cassandra_adapter.rb - About 2 hrs to fix

        Method cassandra_cluster_options has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def cassandra_cluster_options
        cluster_options = config.slice(*[
            :auth_provider,
            :client_cert,
            :compression,
        Severity: Major
        Found in lib/cassandra_object/adapters/cassandra_adapter.rb - About 2 hrs to fix

          Method cassandra_cluster_options has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def cassandra_cluster_options
        cluster_options = config.slice(*[
            :auth_provider,
            :client_cert,
            :compression,
          Severity: Major
          Found in lib/cassandra_object/adapters/cassandra_schemaless_adapter.rb - About 2 hrs to fix

            Method guess_type has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

                  def self.guess_type(object)

        if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.4.0')
          case object
            when ::String then
            Severity: Minor
            Found in lib/cassandra_object/types/type_helper.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method select_records has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def select_records(auto_paginate = true)
      results = []
      records = {}
      new_next_cursor = nil
            Severity: Minor
            Found in lib/cassandra_object/scope.rb - About 1 hr to fix

              Method statement_create_with_options has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def statement_create_with_options(stmt, options)
        if !options.nil?
          statement_with_options stmt, options
        else
          # standard
              Severity: Minor
              Found in lib/cassandra_object/adapters/cassandra_schemaless_adapter.rb - About 1 hr to fix

                Method statement_create_with_options has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def statement_create_with_options(stmt, options = '')
        if !options.nil?
          statement_with_options stmt, options
        else
          # standard
                Severity: Minor
                Found in lib/cassandra_object/adapters/cassandra_adapter.rb - About 1 hr to fix

                  Consider simplifying this complex logical expression.
                  Open

                        if (klass == Base || klass.superclass == Base) || (klass == BaseSchemaless || klass.superclass == BaseSchemaless) || (klass == BaseSchema || klass.superclass == BaseSchema) || (klass == BaseSchemalessDynamic || klass.superclass == BaseSchemalessDynamic)
        klass
      elsif klass.superclass.nil?
        raise "#{name} doesn't belong in a hierarchy descending from CassandraObject"
      else
                  Severity: Critical
                  Found in lib/cassandra_object/model.rb - About 1 hr to fix

                    Method where_string_async has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                            def where_string_async(ids)
          conditions = []

          if ids.present?
            conditions << if ids.size > 1
                    Severity: Minor
                    Found in lib/cassandra_object/adapters/cassandra_schemaless_adapter.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method cassandra_cluster_options has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def cassandra_cluster_options
        cluster_options = config.slice(*[
            :auth_provider,
            :client_cert,
            :compression,
                    Severity: Minor
                    Found in lib/cassandra_object/adapters/cassandra_adapter.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method find_some has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                            def find_some(pids)
          ids = pids.flatten.compact.uniq.map(&:to_s)
          return [] if ids.empty?

          qr = where_ids(ids).execute
                    Severity: Minor
                    Found in lib/cassandra_object/scope/finder_methods.rb - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method cassandra_cluster_options has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def cassandra_cluster_options
        cluster_options = config.slice(*[
            :auth_provider,
            :client_cert,
            :compression,
                    Severity: Minor
                    Found in lib/cassandra_object/adapters/cassandra_schemaless_adapter.rb - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                              if ids.present?
            conditions << if ids.size > 1
              "#{@adapter.primary_key_column} IN (#{ids.map { |id| "'#{id}'" }.join(',')})"
            else
              "#{@adapter.primary_key_column} = '#{ids.first}'"
                    Severity: Minor
                    Found in lib/cassandra_object/adapters/cassandra_schemaless_adapter.rb and 1 other location - About 35 mins to fix
                    lib/cassandra_object/adapters/cassandra_adapter.rb on lines 45..49

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 36.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language