Similar blocks of code found in 2 locations. Consider refactoring.

Open

def p4_sync(f, *options):
    p4_system(["sync"] + list(options) + [wildcard_encode(f)])

• Read up
  Read up

Avoid deeply nested control flow statements.

Open

                        for (prev, cur) in zip(self.previousDepotPaths, depotPaths):
                            prev_list = prev.split("/")
                            cur_list = cur.split("/")
                            for i in range(0, min(len(cur_list), len(prev_list))):
                                if cur_list[i] != prev_list[i]:

Avoid deeply nested control flow statements.

Open

                    if len(cdup) > 0:
                        chdir(cdup)

Avoid deeply nested control flow statements.

Open

                if (!('previous' in curCommit)) {
                    var parts = data.split(' ', 2);
                    curCommit.previous    = parts[0];
                    curCommit.file_parent = unquote(parts[1]);
                }

Avoid deeply nested control flow statements.

Open

                    if not m:
                        m = re.search(r'Request too large \(over (\d+)\)', data)

Avoid deeply nested control flow statements.

Open

                        if not self.silent:
                            print("p4 branch %s defines a mapping from %s to %s" % (info["branch"], source, destination))
                            print("but there exists another mapping from %s to %s already!" % (self.knownBranches[destination], destination))
                        continue

Avoid deeply nested control flow statements.

Open

                            if parent == branch:
                                parent = ""
                            else:
                                fullBranch = self.projectName + branch
                                if fullBranch not in self.p4BranchesInGit:

Avoid deeply nested control flow statements.

Open

                    if (fragment) {
                        td_sha1.appendChild(fragment);
                    }

Avoid deeply nested control flow statements.

Open

                            if self.verbose:
                                print("Parent of %s not found. Committing into head of %s" % (branch, parent))
                            self.commit(description, filesForCommit, branch, parent)

Function searchParent has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    def searchParent(self, parent, branch, target):
        targetTree = read_pipe(["git", "rev-parse",
                                "{}^{{tree}}".format(target)]).strip()
        for line in read_pipe_lines(["git", "rev-list", "--format=%H %T",
                                     "--no-merges", parent]):

• Read up
  Read up

Avoid deeply nested control flow statements.

Open

                            if self.verbose:
                                print("Creating temporary branch: " + tempBranch)
                            self.commit(description, filesForCommit, tempBranch)

Function p4_build_cmd has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

def p4_build_cmd(cmd):
    """Build a suitable p4 command line.

       This consolidates building and returning a p4 command line into one
       location. It means that hooking into the environment, or other

• Read up
  Read up

Avoid deeply nested control flow statements.

Open

                    if m:
                        limit = int(m.group(1))
                        raise P4RequestSizeException(exitCode, result, limit)

Function edit_template has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    def edit_template(self, template_file):
        """Invoke the editor to let the user change the submission message.

           Return true if okay to continue with the submit.
           """

• Read up
  Read up

Function exceedsLargeFileThreshold has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    def exceedsLargeFileThreshold(self, relPath, contents):
        if gitConfigInt('git-p4.largeFileThreshold'):
            contentsSize = sum(len(d) for d in contents)
            if contentsSize > gitConfigInt('git-p4.largeFileThreshold'):
                return True

• Read up
  Read up

Avoid deeply nested control flow statements.

Open

                    if originP4Change > p4Change:
                        print("%s (%s) is newer than %s (%s). "
                               "Updating p4 branch from origin."
                               % (originHead, originP4Change,
                                  remoteHead, p4Change))

Avoid deeply nested control flow statements.

Open

                        for line in read_pipe_lines(
                                ["git", "diff", "%s^..%s" % (id, id), file],
                                raw=True):
                            if regexp.search(line):
                                if verbose:

Avoid deeply nested control flow statements.

Open

                        if branch_arg_given:
                            raise P4CommandException("Error: branch %s does not exist." % self.branch)
                        else:
                            raise P4CommandException("Error: no branch %s; perhaps specify one with --branch." %
                                self.branch)

Method Client.connect has 6 return statements (exceeds 4 allowed).

Open

func (c *Client) connect() (uconn net.Conn, hconn net.Conn, addr string, err error) {
    uconn, err = DefaultSocket.Dial()
    if err != nil {
        if e, ok := err.(*net.OpError); ok && (os.IsNotExist(e.Err) || e.Err == syscall.ECONNREFUSED) {
            if err = c.startProxy(); err == nil {

Function commit has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def commit(self, details, files, branch, parent="", allow_empty=False):