Sign upLogin

gitcoinco/code_fund_ads

View on GitHub
Star
app/models/pixel.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method record_conversion has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def record_conversion(impression_id_param, conversion_referrer: nil, test: false, metadata: {})
    impression = Impression.find_by(id: impression_id_param, organization_id: organization_id) if UUID.validate(impression_id_param)
    logger.info "Pixel#record_conversion Unable to find an impression for impression_id='#{impression_id_param}' and organization_id='#{organization_id}'." unless impression
    impression_attribute_names = %w[
      advertiser_id
Severity: Minor
Found in app/models/pixel.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status