Sign upLogin

gitlabhq/gitlab-shell

View on GitHub
Star

Showing 79 of 79 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

describe 'Custom bin/gitlab-shell git-receive-pack' do
  include_context 'gitlab shell'

  let(:env) { {'SSH_CONNECTION' => 'fake', 'SSH_ORIGINAL_COMMAND' => 'git-receive-pack group/repo' } }
  let(:divider) { "remote: ========================================================================\n" }
Severity: Major
Found in spec/gitlab_shell_custom_git_receive_pack_spec.rb and 1 other location - About 1 day to fix
spec/gitlab_shell_custom_git_upload_pack_spec.rb on lines 7..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 313.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

describe 'Custom bin/gitlab-shell git-upload-pack' do
  include_context 'gitlab shell'

  let(:env) { {'SSH_CONNECTION' => 'fake', 'SSH_ORIGINAL_COMMAND' => 'git-upload-pack group/repo' } }
  let(:divider) { "remote: ========================================================================\n" }
Severity: Major
Found in spec/gitlab_shell_custom_git_upload_pack_spec.rb and 1 other location - About 1 day to fix
spec/gitlab_shell_custom_git_receive_pack_spec.rb on lines 7..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 313.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function TestListenAndServe_proxyProtocolEnabled has 151 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestListenAndServe_proxyProtocolEnabled(t *testing.T) {
    testRoot := testhelper.PrepareTestRootDir(t)

    target, err := net.ResolveTCPAddr("tcp", serverUrl)
    require.NoError(t, err)
Severity: Major
Found in internal/sshd/sshd_test.go - About 5 hrs to fix

    Function setup has 138 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func setup(t *testing.T, keyId string, repo string, op string) (string, *Command, *pktline.Pktline, *io.PipeReader) {
    var url string

    gitalyAddress, _ := testserver.StartGitalyServer(t, "unix")
    requests := []testserver.TestRequestHandler{
    Severity: Major
    Found in internal/command/lfstransfer/lfstransfer_test.go - About 4 hrs to fix

      Function TestParseSuccess has 132 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func TestParseSuccess(t *testing.T) {
    testCases := []struct {
        desc         string
        executable   *executable.Executable
        env          sshenv.Env
      Severity: Major
      Found in cmd/gitlab-shell/command/command_test.go - About 4 hrs to fix

        Function TestExecute has 106 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func TestExecute(t *testing.T) {
    setup(t)

    url := testserver.StartSocketHttpServer(t, requests)
        Severity: Major
        Found in internal/command/personalaccesstoken/personalaccesstoken_test.go - About 3 hrs to fix

          File lfstransfer_test.go has 527 lines of code (exceeds 500 allowed). Consider refactoring.
          Open

          package lfstransfer

import (
    "context"
    "crypto/hmac"
          Severity: Minor
          Found in internal/command/lfstransfer/lfstransfer_test.go - About 2 hrs to fix

            Function TestLfsAuthenticateRequests has 87 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func TestLfsAuthenticateRequests(t *testing.T) {
    userId := "123"
    operation := "upload"

    requests := []testserver.TestRequestHandler{
            Severity: Major
            Found in internal/command/lfsauthenticate/lfsauthenticate_test.go - About 2 hrs to fix

              Function TestUserCertificateHandling has 82 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func TestUserCertificateHandling(t *testing.T) {
    testRoot := testhelper.PrepareTestRootDir(t)

    validUserCert := userCert(t, ssh.UserCert, time.Now().Add(time.Hour))
              Severity: Major
              Found in internal/sshd/server_config_test.go - About 2 hrs to fix

                Method mock_server has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                Open

                  def mock_server(server)
    server.mount_proc('/api/v4/internal/lfs_authenticate') do |req, res|
      res.content_type = 'application/json'

      key_id = req.query['key_id'] || req.query['user_id']
                Severity: Minor
                Found in spec/gitlab_shell_lfs_authentication_spec.rb - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function TestHandleShell has 76 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func TestHandleShell(t *testing.T) {
    testCases := []struct {
        desc                 string
        cmd                  string
        errMsg               string
                Severity: Major
                Found in internal/sshd/session_test.go - About 2 hrs to fix

                  Function TestNewWithUsername has 75 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                  func TestNewWithUsername(t *testing.T) {
    tests := []struct {
        desc         string
        command      string
        namespace    string
                  Severity: Minor
                  Found in cmd/gitlab-shell/command/command_test.go - About 2 hrs to fix

                    Function TestNew has 72 lines of code (exceeds 50 allowed). Consider refactoring.
                    Open

                    func TestNew(t *testing.T) {
    testCases := []struct {
        desc         string
        executable   *executable.Executable
        env          sshenv.Env
                    Severity: Minor
                    Found in cmd/gitlab-shell/command/command_test.go - About 1 hr to fix

                      Function TestExecute has 71 lines of code (exceeds 50 allowed). Consider refactoring.
                      Open

                      func TestExecute(t *testing.T) {
    setup(t)

    url := testserver.StartSocketHttpServer(t, requests)
                      Severity: Minor
                      Found in internal/command/twofactorrecover/twofactorrecover_test.go - About 1 hr to fix

                        Function TestReceivePack has 70 lines of code (exceeds 50 allowed). Consider refactoring.
                        Open

                        func TestReceivePack(t *testing.T) {
    for _, network := range []string{"unix", "tcp", "dns"} {
        t.Run(fmt.Sprintf("via %s network", network), func(t *testing.T) {
            gitalyAddress, testServer := testserver.StartGitalyServer(t, network)
            t.Log(fmt.Sprintf("Server address: %s", gitalyAddress))
                        Severity: Minor
                        Found in internal/command/receivepack/gitalycall_test.go - About 1 hr to fix

                          Function TestClients has 69 lines of code (exceeds 50 allowed). Consider refactoring.
                          Open

                          func TestClients(t *testing.T) {
    testRoot := testhelper.PrepareTestRootDir(t)

    testCases := []struct {
        desc            string
                          Severity: Minor
                          Found in client/client_test.go - About 1 hr to fix

                            Function TestExecute has 68 lines of code (exceeds 50 allowed). Consider refactoring.
                            Open

                            func TestExecute(t *testing.T) {
    requests := setup(t)

    url := testserver.StartSocketHttpServer(t, requests)
                            Severity: Minor
                            Found in internal/command/twofactorverify/twofactorverify_test.go - About 1 hr to fix

                              Function TestUserKeyHandling has 67 lines of code (exceeds 50 allowed). Consider refactoring.
                              Open

                              func TestUserKeyHandling(t *testing.T) {
    testRoot := testhelper.PrepareTestRootDir(t)

    validRSAKey := rsaPublicKey(t)
                              Severity: Minor
                              Found in internal/sshd/server_config_test.go - About 1 hr to fix

                                Method mock_server has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                                Open

                                  def mock_server(server)
    server.mount_proc('/api/v4/internal/two_factor_manual_otp_check') do |req, res|
      res.content_type = 'application/json'
      res.status = 200
                                Severity: Minor
                                Found in spec/gitlab_shell_two_factor_verify_spec.rb - About 1 hr to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Method mock_server has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                  def mock_server(server)
    server.mount_proc('/geo/proxy_git_ssh/info_refs_upload_pack') do |req, res|
      res.content_type = 'application/json'
      res.status = 200
                                Severity: Minor
                                Found in spec/gitlab_shell_custom_git_upload_pack_spec.rb - About 1 hr to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language