Sign upLogin

gitlabhq/grit

View on GitHub
Star
lib/grit/diff.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method list_from_string has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def self.list_from_string(repo, text)
      lines = text.split("\n")

      diffs = []
Severity: Minor
Found in lib/grit/diff.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method list_from_string has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.list_from_string(repo, text)
      lines = text.split("\n")

      diffs = []
Severity: Minor
Found in lib/grit/diff.rb - About 1 hr to fix

    Method initialize has 12 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def initialize(repo, a_path, b_path, a_blob, b_blob, a_mode, b_mode, new_file, deleted_file, diff, renamed_file = false, similarity_index = 0)
    Severity: Major
    Found in lib/grit/diff.rb - About 1 hr to fix

      Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(repo, a_path, b_path, a_blob, b_blob, a_mode, b_mode, new_file, deleted_file, diff, renamed_file = false, similarity_index = 0)
      @repo   = repo
      @a_path = a_path
      @b_path = b_path
      @a_blob = a_blob =~ /^0{40}$/ ? nil : Blob.create(repo, :id => a_blob)
      Severity: Minor
      Found in lib/grit/diff.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status