Sign upLogin

gitshowcase/gitshowcase

View on GitHub
Star

Showing 883 of 883 total issues

Perceived complexity for github is too high. [9/7]
Open

  def github
    auth = request.env['omniauth.auth']

    @user = User.where(github_uid: auth.uid).first_or_initialize
    github_user_service = GithubUserService.new(@user)
Severity: Minor
Found in app/controllers/users/omniauth_callbacks_controller.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Assignment Branch Condition size for set is too high. [17.38/15]
Open

  def set(field, value)
    field = field.to_sym

    field = :socials if User::SOCIALS.key?(field)
    return unless FIELDS.key? field
Severity: Minor
Found in app/services/user/completeness_service.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Cyclomatic complexity for sync is too high. [8/6]
Open

  def sync
    raise "Project ##{@project.id} - #{@project.title} does not have a homepage to sync" unless @project.homepage.present?

    params = {connection_timeout: 5, read_timeout: 3, retries: 0, download_images: false}
    page = MetaInspector.new(@project.homepage, params) rescue nil
Severity: Minor
Found in app/services/project_inspector_service.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method has too many lines. [12/10]
Open

  def change
    create_table :projects do |t|
      t.string :title
      t.string :homepage
      t.string :repository
Severity: Minor
Found in db/migrate/20170111023844_create_projects.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for update_domain is too high. [16.76/15]
Open

  def update_domain
    old_domain = @user.domain
    new_domain = user_params(:domain)[:domain]

    if old_domain != new_domain
Severity: Minor
Found in app/controllers/dashboard/users_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Cyclomatic complexity for github is too high. [7/6]
Open

  def github
    auth = request.env['omniauth.auth']

    @user = User.where(github_uid: auth.uid).first_or_initialize
    github_user_service = GithubUserService.new(@user)
Severity: Minor
Found in app/controllers/users/omniauth_callbacks_controller.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method has too many lines. [11/10]
Open

  def import
    countries = Hash[Country.all.map { |country| [country.abbreviation, country.id] }]

    timezones = yaml_records.map do |record|
      Timezone.new(
Severity: Minor
Found in app/services/import/timezone_service.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

  def self.sync_projects(projects)
    result = []

    Project.transaction do
      projects.map do |project|
Severity: Minor
Found in app/services/project_inspector_service.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Perceived complexity for sync is too high. [8/7]
Open

  def sync
    raise "Project ##{@project.id} - #{@project.title} does not have a homepage to sync" unless @project.homepage.present?

    params = {connection_timeout: 5, read_timeout: 3, retries: 0, download_images: false}
    page = MetaInspector.new(@project.homepage, params) rescue nil
Severity: Minor
Found in app/services/project_inspector_service.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Cyclomatic complexity for set is too high. [7/6]
Open

  def set(skills)
    keys = skills.keys
    skills = convert_from_arrays(skills) if keys.size == 2 && keys.include?(:name) && keys.include?(:mastery)

    parsed = {}
Severity: Minor
Found in app/services/user/skills_service.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method has too many lines. [11/10]
Open

  def set(skills)
    keys = skills.keys
    skills = convert_from_arrays(skills) if keys.size == 2 && keys.include?(:name) && keys.include?(:mastery)

    parsed = {}
Severity: Minor
Found in app/services/user/skills_service.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method github has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def github
    auth = request.env['omniauth.auth']

    @user = User.where(github_uid: auth.uid).first_or_initialize
    github_user_service = GithubUserService.new(@user)
Severity: Minor
Found in app/controllers/users/omniauth_callbacks_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Assignment Branch Condition size for import is too high. [15.13/15]
Open

  def import
    countries = Hash[Country.all.map { |country| [country.abbreviation, country.id] }]

    timezones = yaml_records.map do |record|
      Timezone.new(
Severity: Minor
Found in app/services/import/timezone_service.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Block has too many lines. [41/25]
Open

    context 'with app domain' do
      before { ENV['APP_DOMAIN'] = 'app-domain.com' }

      describe '#initialize' do
        it 'does not allow app domain to be used' do
Severity: Minor
Found in spec/services/domain_service_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [40/25]
Open

RSpec.describe EmailSubscriptionService, type: :service do
  context 'enabled' do
    let!(:client_member) { double.as_null_object }

    before {
Severity: Minor
Found in spec/services/email_subscription_service_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Method index has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def index
    @levels = levels = User::CompletenessService::LEVELS.keys
    @search_fields = SEARCH_FIELDS

    query = User.order('id DESC')
Severity: Minor
Found in app/controllers/admin/users_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sync has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def sync
    raise "Project ##{@project.id} - #{@project.title} does not have a homepage to sync" unless @project.homepage.present?

    params = {connection_timeout: 5, read_timeout: 3, retries: 0, download_images: false}
    page = MetaInspector.new(@project.homepage, params) rescue nil
Severity: Minor
Found in app/services/project_inspector_service.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method change has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def change
    create_table :snapshots do |t|
      t.date :date, null: false

      # Total values
Severity: Minor
Found in db/migrate/20170502201750_create_snapshots.rb - About 1 hr to fix

    Method github has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def github
    auth = request.env['omniauth.auth']

    @user = User.where(github_uid: auth.uid).first_or_initialize
    github_user_service = GithubUserService.new(@user)
    Severity: Minor
    Found in app/controllers/users/omniauth_callbacks_controller.rb - About 1 hr to fix

      Method index has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def index
    @levels = levels = User::CompletenessService::LEVELS.keys
    @search_fields = SEARCH_FIELDS

    query = User.order('id DESC')
      Severity: Minor
      Found in app/controllers/admin/users_controller.rb - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language