Sign upLogin

giuse/machine_learning_workbench

View on GitHub
Star
lib/machine_learning_workbench/monkey.rb

Summary

Maintainability
A
0 mins
Test Coverage

Assignment Branch Condition size for exponential is too high. [19.21/15]
Open

    def exponential
      raise ArgumentError if ndim > 2
      # special case: one-dimensional matrix: just exponentiate the values
      return NMath.exp(self) if (ndim == 1) || shape.include?(1)
      # at this point we need to validate it is a square matrix
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for map is too high. [16.55/15]
Open

    def map dim=0
      raise ArgumentError unless dim.kind_of?(Integer) && dim.between?(0,ndim)
      # TODO: return iterator instead of raise
      raise NotImplementedError unless block_given?
      indices = [true]*ndim
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Space missing after comma.
Open

            ret[r,c] = yield self[r], other[c]
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Checks for comma (,) not followed by some kind of space.

Example:

# bad
[1,2]
{ foo:bar,}

# good
[1, 2]
{ foo:bar, }

Surrounding space missing in default value assignment.
Open

    def approximates? other, epsilon=1e-5
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.

Example:

# bad
def some_method(arg1=:default, arg2=nil, arg3=[])
  # do something...
end

# good
def some_method(arg1 = :default, arg2 = nil, arg3 = [])
  # do something...
end

Line is too long. [86/80]
Open

  #       :t,           # compute right eigenvectors of A? (left eigenvectors of A**T)
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Line is too long. [81/80]
Open

  #     # Given the use I make (near-equality), I choose the first interpretation
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Prefer Object#is_a? over Object#kind_of?.
Open

      if first.kind_of? Array
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop enforces consistent use of Object#is_a? or Object#kind_of?.

Example: EnforcedStyle: is_a? (default)

# bad
var.kind_of?(Date)
var.kind_of?(Integer)

# good
var.is_a?(Date)
var.is_a?(Integer)

Example: EnforcedStyle: kind_of?

# bad
var.is_a?(Time)
var.is_a?(String)

# good
var.kind_of?(Time)
var.kind_of?(String)

Use def with parentheses when there are parameters.
Open

    def outer_flat other
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cops checks for parentheses around the arguments in method definitions. Both instance and class/singleton methods are checked.

Example: EnforcedStyle: require_parentheses (default)

# The `require_parentheses` style requires method definitions
# to always use parentheses

# bad
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

Example: EnforcedStyle: requirenoparentheses

# The `require_no_parentheses` style requires method definitions
# to never use parentheses

# bad
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

Example: EnforcedStyle: requirenoparenthesesexceptmultiline

# The `require_no_parentheses_except_multiline` style prefers no
# parantheses when method definition arguments fit on single line,
# but prefers parantheses when arguments span multiple lines.

# bad
def bar(num1, num2)
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

Line is too long. [91/80]
Open

  #   # `#matrix_norm`, with a decent choice of norms to choose from. Unfortunately, as the
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Use nested module/class definitions instead of compact style.
Open

module MachineLearningWorkbench::Monkey
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Use def with parentheses when there are parameters.
Open

    def map dim=0
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cops checks for parentheses around the arguments in method definitions. Both instance and class/singleton methods are checked.

Example: EnforcedStyle: require_parentheses (default)

# The `require_parentheses` style requires method definitions
# to always use parentheses

# bad
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

Example: EnforcedStyle: requirenoparentheses

# The `require_no_parentheses` style requires method definitions
# to never use parentheses

# bad
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

Example: EnforcedStyle: requirenoparenthesesexceptmultiline

# The `require_no_parentheses_except_multiline` style prefers no
# parantheses when method definition arguments fit on single line,
# but prefers parantheses when arguments span multiple lines.

# bad
def bar(num1, num2)
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      raise ArgumentError, "Need to pass an operand block" unless block_given?
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Missing space after #.
Open

      r_evecs_t = r_evecs#.transpose
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Space missing after comma.
Open

          m.each_stored_with_indices do |_,*idxs|
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Checks for comma (,) not followed by some kind of space.

Example:

# bad
[1,2]
{ foo:bar,}

# good
[1, 2]
{ foo:bar, }

Line is too long. [88/80]
Open

  #   # and calling it on a matrix returns NotImplementedError :) you have to toggle the
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Line is too long. [88/80]
Open

      # TODO: Xumo::NArray should be able to implement this with `#outer` and some other
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Missing top-level module documentation comment.
Open

  module Buildable
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Surrounding space missing in default value assignment.
Open

    def approximates? other, epsilon=1e-5
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.

Example:

# bad
def some_method(arg1=:default, arg2=nil, arg3=[])
  # do something...
end

# good
def some_method(arg1 = :default, arg2 = nil, arg3 = [])
  # do something...
end

Surrounding space missing for operator *.
Open

      indices = [true]*ndim
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Checks that operators have space around them, except for ** which should not have surrounding space.

Example:

# bad
total = 3*4
"apple"+"juice"
my_number = 38/4
a ** b

# good
total = 3 * 4
"apple" + "juice"
my_number = 38 / 4
a**b

Missing top-level module documentation comment.
Open

  module NumericallyApproximatable
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level module documentation comment.
Open

  module Mappable
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Ambiguous splat operator. Parenthesize the method arguments if it's surely a splat operator, or add a whitespace to the right of the * if it should be a multiplication.
Open

            m[*idxs] = yield *idxs
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks for ambiguous operators in the first argument of a method invocation without parentheses.

Example:

# bad

# The `*` is interpreted as a splat operator but it could possibly be
# a `*` method invocation (i.e. `do_something.*(some_array)`).
do_something *some_array

Example:

# good

# With parentheses, there's no ambiguity.
do_something(*some_array)

Line is too long. [91/80]
Open

  #   # What can I say, we're back to referencing rows by index. I am just wasting too much
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Line is too long. [93/80]
Open

      evals, _wi, _vl, r_evecs = NLinalg::Lapack.call(:geev, self, jobvl: false, jobvr: true)
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Missing top-level module documentation comment.
Open

  module NArrayOuterFlattable
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use def with parentheses when there are parameters.
Open

    def new *args
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cops checks for parentheses around the arguments in method definitions. Both instance and class/singleton methods are checked.

Example: EnforcedStyle: require_parentheses (default)

# The `require_parentheses` style requires method definitions
# to always use parentheses

# bad
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

Example: EnforcedStyle: requirenoparentheses

# The `require_no_parentheses` style requires method definitions
# to never use parentheses

# bad
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

Example: EnforcedStyle: requirenoparenthesesexceptmultiline

# The `require_no_parentheses_except_multiline` style prefers no
# parantheses when method definition arguments fit on single line,
# but prefers parantheses when arguments span multiple lines.

# bad
def bar(num1, num2)
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

Line is too long. [84/80]
Open

  #     raise StorageTypeError, "Only dense matrices (because LAPACK)" unless dense?
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Line is too long. [87/80]
Open

  #   # time figuring out these details to write a generalized version with an optional
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Surrounding space missing in default value assignment.
Open

    def map dim=0
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.

Example:

# bad
def some_method(arg1=:default, arg2=nil, arg3=[])
  # do something...
end

# good
def some_method(arg1 = :default, arg2 = nil, arg3 = [])
  # do something...
end

Line is too long. [90/80]
Open

  #   # to compute the norm of a matrix. Fun fact: that is the implementation for vectors,
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Line is too long. [90/80]
Open

  #   # So I resigned to dance to `Array`s and back, and implemented it with `#each_rank`.
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Line is too long. [90/80]
Open

# require 'nmatrix/lapack_plugin' # loads whichever is installed between atlas and lapacke
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Missing top-level module documentation comment.
Open

  module NArrayApproximatable
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [83/80]
Open

  #   #   A value different than `:both` for param `which` reduces the return size.
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Redundant self detected.
Open

        self.size.times do |r|
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks for redundant uses of self.

The usage of self is only needed when:

  • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

  • Calling an attribute writer to prevent an local variable assignment.

Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

Note we allow uses of self with operators because it would be awkward otherwise.

Example:

# bad
def foo(bar)
  self.baz
end

# good
def foo(bar)
  self.bar  # Resolves name clash with the argument.
end

def foo
  bar = 1
  self.bar  # Resolves name clash with the local variable.
end

def foo
  %w[x y z].select do |bar|
    self.bar == bar  # Resolves name clash with argument of the block.
  end
end

Space missing after comma.
Open

      raise ArgumentError unless dim.kind_of?(Integer) && dim.between?(0,ndim)
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Checks for comma (,) not followed by some kind of space.

Example:

# bad
[1,2]
{ foo:bar,}

# good
[1, 2]
{ foo:bar, }

Line is too long. [88/80]
Open

  #     raise ShapeError, "Only square matrices" unless dim == 2 && shape[0] == shape[1]
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Line is too long. [84/80]
Open

  #   # The NMatrix documentation refers to a function `#nrm2` (aliased to `#norm2`)
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Line is too long. [84/80]
Open

  #   # Unexplicably, I get a list of constant values as the return value; same with
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Missing top-level module documentation comment.
Open

  module Exponentiable
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use def with parentheses when there are parameters.
Open

    def dims ret: []
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cops checks for parentheses around the arguments in method definitions. Both instance and class/singleton methods are checked.

Example: EnforcedStyle: require_parentheses (default)

# The `require_parentheses` style requires method definitions
# to always use parentheses

# bad
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

Example: EnforcedStyle: requirenoparentheses

# The `require_no_parentheses` style requires method definitions
# to never use parentheses

# bad
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

Example: EnforcedStyle: requirenoparenthesesexceptmultiline

# The `require_no_parentheses_except_multiline` style prefers no
# parantheses when method definition arguments fit on single line,
# but prefers parantheses when arguments span multiple lines.

# bad
def bar(num1, num2)
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

Extra blank line detected.
Open


  #   # The NMatrix documentation refers to a function `#nrm2` (aliased to `#norm2`)
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cops checks for two or more consecutive blank lines.

Example:

# bad - It has two empty lines.
some_method
# one empty line
# two empty lines
some_method

# good
some_method
# one empty line
some_method

Line is too long. [84/80]
Open

  #       e_values_img, # imaginary part of computed eigenvalues (will be discarded)
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Line is too long. [81/80]
Open

      # Used for testing and NMatrix#approximates?, should I move to spec_helper?
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Line is too long. [90/80]
Open

      # Eigenvalue decomposition method from `scipy/linalg/matfuncs.py#expm2` (deprecated)
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Missing top-level module documentation comment.
Open

  module ToNArrayConvertible
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Extra empty line detected at module body end.
Open


end
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cops checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

Missing top-level module documentation comment.
Open

  module Dimensionable
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use def with parentheses when there are parameters.
Open

    def approximates? other, epsilon=1e-5
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cops checks for parentheses around the arguments in method definitions. Both instance and class/singleton methods are checked.

Example: EnforcedStyle: require_parentheses (default)

# The `require_parentheses` style requires method definitions
# to always use parentheses

# bad
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

Example: EnforcedStyle: requirenoparentheses

# The `require_no_parentheses` style requires method definitions
# to never use parentheses

# bad
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

Example: EnforcedStyle: requirenoparenthesesexceptmultiline

# The `require_no_parentheses_except_multiline` style prefers no
# parantheses when method definition arguments fit on single line,
# but prefers parantheses when arguments span multiple lines.

# bad
def bar(num1, num2)
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

Redundant self detected.
Open

      self.class.zeros([self.size, other.size]).tap do |ret|
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks for redundant uses of self.

The usage of self is only needed when:

  • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

  • Calling an attribute writer to prevent an local variable assignment.

Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

Note we allow uses of self with operators because it would be awkward otherwise.

Example:

# bad
def foo(bar)
  self.baz
end

# good
def foo(bar)
  self.bar  # Resolves name clash with the argument.
end

def foo
  bar = 1
  self.bar  # Resolves name clash with the local variable.
end

def foo
  %w[x y z].select do |bar|
    self.bar == bar  # Resolves name clash with argument of the block.
  end
end

Put a space before an end-of-line comment.
Open

      r_evecs_t = r_evecs#.transpose
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks for missing space between a token and a comment on the same line.

Example:

# bad
1 + 1# this operation does ...

# good
1 + 1 # this operation does ...

Line is too long. [81/80]
Open

    # NOTE: this indexing is not consistent with NArray, which uses 0 to indicate
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

Prefer Object#is_a? over Object#kind_of?.
Open

      raise ArgumentError unless dim.kind_of?(Integer) && dim.between?(0,ndim)
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop enforces consistent use of Object#is_a? or Object#kind_of?.

Example: EnforcedStyle: is_a? (default)

# bad
var.kind_of?(Date)
var.kind_of?(Integer)

# good
var.is_a?(Date)
var.is_a?(Integer)

Example: EnforcedStyle: kind_of?

# bad
var.is_a?(Time)
var.is_a?(String)

# good
var.kind_of?(Time)
var.kind_of?(String)

Missing top-level module documentation comment.
Open

  module Invertable
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use def with parentheses when there are parameters.
Open

    def approximates? other, epsilon=1e-5
Severity: Minor
Found in lib/machine_learning_workbench/monkey.rb by rubocop

This cops checks for parentheses around the arguments in method definitions. Both instance and class/singleton methods are checked.

Example: EnforcedStyle: require_parentheses (default)

# The `require_parentheses` style requires method definitions
# to always use parentheses

# bad
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

Example: EnforcedStyle: requirenoparentheses

# The `require_no_parentheses` style requires method definitions
# to never use parentheses

# bad
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

Example: EnforcedStyle: requirenoparenthesesexceptmultiline

# The `require_no_parentheses_except_multiline` style prefers no
# parantheses when method definition arguments fit on single line,
# but prefers parantheses when arguments span multiple lines.

# bad
def bar(num1, num2)
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

There are no issues that match your filters.

Category
Status