Sign upLogin

giuse/machine_learning_workbench

View on GitHub
Star
lib/machine_learning_workbench/neural_network/recurrent.rb

Summary

Maintainability
A
0 mins
Test Coverage

Assignment Branch Condition size for activate_layer is too high. [20.22/15]
Open

    def activate_layer nlay
      # Mark begin and end of recursion outputs in current state
      begin_recur = nneurs(nlay)
      end_recur = nneurs(nlay) + nneurs(nlay+1)
      # Copy the level's last-time activation to the current input recurrency
Severity: Minor
Found in lib/machine_learning_workbench/neural_network/recurrent.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Incorrect indentation detected (column 6 instead of 4).
Open

      # act_fn.call state[previous].dot layers[nlay]
Severity: Minor
Found in lib/machine_learning_workbench/neural_network/recurrent.rb by rubocop

This cops checks the indentation of comments.

Example:

# bad
  # comment here
def method_name
end

  # comment here
a = 'hello'

# yet another comment
  if true
    true
  end

# good
# comment here
def method_name
end

# comment here
a = 'hello'

# yet another comment
if true
  true
end

Extra empty line detected at class body end.
Open


  end
Severity: Minor
Found in lib/machine_learning_workbench/neural_network/recurrent.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Use nested module/class definitions instead of compact style.
Open

module MachineLearningWorkbench::NeuralNetwork
Severity: Minor
Found in lib/machine_learning_workbench/neural_network/recurrent.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Use def with parentheses when there are parameters.
Open

    def activate_layer nlay
Severity: Minor
Found in lib/machine_learning_workbench/neural_network/recurrent.rb by rubocop

This cops checks for parentheses around the arguments in method definitions. Both instance and class/singleton methods are checked.

Example: EnforcedStyle: require_parentheses (default)

# The `require_parentheses` style requires method definitions
# to always use parentheses

# bad
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

Example: EnforcedStyle: requirenoparentheses

# The `require_no_parentheses` style requires method definitions
# to never use parentheses

# bad
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

Example: EnforcedStyle: requirenoparenthesesexceptmultiline

# The `require_no_parentheses_except_multiline` style prefers no
# parantheses when method definition arguments fit on single line,
# but prefers parantheses when arguments span multiple lines.

# bad
def bar(num1, num2)
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

Surrounding space missing for operator +.
Open

      state[nlay][begin_recur...end_recur] = state[nlay+1][0...nneurs(nlay+1)]
Severity: Minor
Found in lib/machine_learning_workbench/neural_network/recurrent.rb by rubocop

Checks that operators have space around them, except for ** which should not have surrounding space.

Example:

# bad
total = 3*4
"apple"+"juice"
my_number = 38/4
a ** b

# good
total = 3 * 4
"apple" + "juice"
my_number = 38 / 4
a**b

Surrounding space missing for operator +.
Open

      end_recur = nneurs(nlay) + nneurs(nlay+1)
Severity: Minor
Found in lib/machine_learning_workbench/neural_network/recurrent.rb by rubocop

Checks that operators have space around them, except for ** which should not have surrounding space.

Example:

# bad
total = 3*4
"apple"+"juice"
my_number = 38/4
a ** b

# good
total = 3 * 4
"apple" + "juice"
my_number = 38 / 4
a**b

Surrounding space missing for operator +.
Open

      state[nlay][begin_recur...end_recur] = state[nlay+1][0...nneurs(nlay+1)]
Severity: Minor
Found in lib/machine_learning_workbench/neural_network/recurrent.rb by rubocop

Checks that operators have space around them, except for ** which should not have surrounding space.

Example:

# bad
total = 3*4
"apple"+"juice"
my_number = 38/4
a ** b

# good
total = 3 * 4
"apple" + "juice"
my_number = 38 / 4
a**b

Extra empty line detected at class body beginning.
Open


    # Calculate the size of each row in a layer's weight matrix.
Severity: Minor
Found in lib/machine_learning_workbench/neural_network/recurrent.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Line is too long. [81/80]
Open

      #   # Copy output from last-time activation to recurrency in previous state
Severity: Minor
Found in lib/machine_learning_workbench/neural_network/recurrent.rb by rubocop

There are no issues that match your filters.

Category
Status