Sign upLogin

glaciers-in-archives/snowman

View on GitHub
Star
internal/template/child_template_function/include.go

Summary

Maintainability
A
3 hrs
Test Coverage

Function include has 6 return statements (exceeds 4 allowed).
Open

func include(templatePath string, arguments ...interface{}) (html_template.HTML, error) {
    templatePath = "templates/" + templatePath
    if _, err := os.Stat(templatePath); err != nil {
        return "", errors.New("Unable to find the template file " + templatePath)
    }
Severity: Major
Found in internal/template/child_template_function/include.go - About 40 mins to fix

    Function include_text has 6 return statements (exceeds 4 allowed).
    Open

    func include_text(templatePath string, arguments ...interface{}) (string, error) {
    templatePath = "templates/" + templatePath
    if _, err := os.Stat(templatePath); err != nil {
        return "", errors.New("Unable to find the template file " + templatePath)
    }
    Severity: Major
    Found in internal/template/child_template_function/include.go - About 40 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          switch len(arguments) {
    case 0:
        if err := tpl.ExecuteTemplate(&renderedTpl, filepath.Base(templatePath), nil); err != nil {
            return "", err
        }
      Severity: Major
      Found in internal/template/child_template_function/include.go and 1 other location - About 1 hr to fix
      internal/template/child_template_function/include.go on lines 26..39

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 144.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          switch len(arguments) {
    case 0:
        if err := tpl.ExecuteTemplate(&renderedTpl, filepath.Base(templatePath), nil); err != nil {
            return "", err
        }
      Severity: Major
      Found in internal/template/child_template_function/include.go and 1 other location - About 1 hr to fix
      internal/template/child_template_function/include.go on lines 56..69

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 144.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status