Sign upLogin

glauberportella/cnab-layouts-parser

View on GitHub
Star
src/CnabParser/Input/RetornoFile.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method decodeLotesCnab240 has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function decodeLotesCnab240()
    {
        $defTipoRegistro = array(
            'pos' => array(8, 8),
            'picture' => '9(1)',
Severity: Major
Found in src/CnabParser/Input/RetornoFile.php - About 2 hrs to fix

    Method decodeLotesCnab400 has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function decodeLotesCnab400()
    {
        $defTipoRegistro = array(
            'pos' => array(1, 1),
            'picture' => '9(1)',
    Severity: Minor
    Found in src/CnabParser/Input/RetornoFile.php - About 1 hr to fix

      Function decodeLotesCnab240 has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          private function decodeLotesCnab240()
    {
        $defTipoRegistro = array(
            'pos' => array(8, 8),
            'picture' => '9(1)',
      Severity: Minor
      Found in src/CnabParser/Input/RetornoFile.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function decodeLotesCnab400 has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private function decodeLotesCnab400()
    {
        $defTipoRegistro = array(
            'pos' => array(1, 1),
            'picture' => '9(1)',
      Severity: Minor
      Found in src/CnabParser/Input/RetornoFile.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid unused parameters such as '$path'.
      Open

          public function generate($path = null)
      Severity: Minor
      Found in src/CnabParser/Input/RetornoFile.php by phpmd

      UnusedFormalParameter

      Since: 0.2

      Avoid passing parameters to methods or constructors and then not using those parameters.

      Example

      class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

      Avoid unused local variables such as '$titulos'.
      Open

              $titulos = array(); // titulos tem titulo
      Severity: Minor
      Found in src/CnabParser/Input/RetornoFile.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$numeroRegistro'.
      Open

                          $numeroRegistro = $linha->obterValorCampo($defNumeroRegistro);
      Severity: Minor
      Found in src/CnabParser/Input/RetornoFile.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$numeroRegistro'.
      Open

                  $numeroRegistro = $linha->obterValorCampo($defNumeroRegistro);
      Severity: Minor
      Found in src/CnabParser/Input/RetornoFile.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$codigoLote'.
      Open

              $codigoLote = null;
      Severity: Minor
      Found in src/CnabParser/Input/RetornoFile.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid excessively long variable names like $ultimoCodigoSegmentoLayout. Keep variable name length under 20.
      Open

              $ultimoCodigoSegmentoLayout = $this->layout->getUltimoCodigoSegmentoRetorno();
      Severity: Minor
      Found in src/CnabParser/Input/RetornoFile.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $primeiroCodigoSegmentoLayout. Keep variable name length under 20.
      Open

              $primeiroCodigoSegmentoLayout = $this->layout->getPrimeiroCodigoSegmentoRetorno();
      Severity: Minor
      Found in src/CnabParser/Input/RetornoFile.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $primeiroCodigoSegmentoLayout. Keep variable name length under 20.
      Open

              $primeiroCodigoSegmentoLayout = $this->layout->getPrimeiroCodigoSegmentoRetorno();
      Severity: Minor
      Found in src/CnabParser/Input/RetornoFile.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $ultimoCodigoSegmentoLayout. Keep variable name length under 20.
      Open

              $ultimoCodigoSegmentoLayout = $this->layout->getUltimoCodigoSegmentoRetorno();
      Severity: Minor
      Found in src/CnabParser/Input/RetornoFile.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $proximoCodigoSegmento. Keep variable name length under 20.
      Open

                          $proximoCodigoSegmento = $proximaLinha->obterValorCampo($defCodigoSegmento);
      Severity: Minor
      Found in src/CnabParser/Input/RetornoFile.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $proximoCodigoSegmento. Keep variable name length under 20.
      Open

                  $proximoCodigoSegmento = $proximaLinha->obterValorCampo($defCodigoSegmento);
      Severity: Minor
      Found in src/CnabParser/Input/RetornoFile.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      There are no issues that match your filters.

      Category
      Status