Sign upLogin

glebm/order_query

View on GitHub
Star

Showing 5 of 5 total issues

Method initialize has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(scope, attr_name, *vals_and_or_dir,
                   unique: nil, nulls: false, sql: nil)
      @name = attr_name
      @order_enum = vals_and_or_dir.shift if vals_and_or_dir[0].is_a?(Array)
      @direction = Direction.parse!(
Severity: Minor
Found in lib/order_query/column.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method enum_side has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def enum_side(value, side, strict = true) # rubocop:disable Metrics/AbcSize
      ord = order_enum
      pos = ord.index(value)
      if pos
        dir = direction
Severity: Minor
Found in lib/order_query/column.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize(scope, attr_name, *vals_and_or_dir,
                   unique: nil, nulls: false, sql: nil)
      @name = attr_name
      @order_enum = vals_and_or_dir.shift if vals_and_or_dir[0].is_a?(Array)
      @direction = Direction.parse!(
Severity: Minor
Found in lib/order_query/column.rb - About 1 hr to fix

    Method default has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def default(scope, dir)
      case connection_adapter(scope)
      when /mysql|maria|sqlite|sqlserver/i
        (dir == :asc ? :first : :last)
      else
    Severity: Minor
    Found in lib/order_query/nulls_direction.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method where_ray has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def where_ray(col, from, mode, strict)
        ["#{col.column_name} "\
         "#{RAY_OP[col.direction(mode == :before)]}#{'=' unless strict} ?",
         [from]].tap do |ray|
          if col.nullable? && col.nulls_direction(mode == :before) == :last
    Severity: Minor
    Found in lib/order_query/sql/where.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language