Sign upLogin

glenux/qasim

View on GitHub
Star

Showing 12 of 12 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  def mount_link name, remotepath
    localpath = File.join ENV['HOME'], "mnt", name
    FileUtils.mkdir_p localpath
    cmd = "sshfs"
    cmd_args = [
Severity: Major
Found in lib/qasim/map/ssh.rb and 1 other location - About 2 hrs to fix
lib/qasim/map/smb.rb on lines 26..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  def mount_link name, remotepath
    localpath = File.join ENV['HOME'], "mnt", name
    FileUtils.mkdir_p localpath
    cmd = "sshfs"
    cmd_args = [
Severity: Major
Found in lib/qasim/map/smb.rb and 1 other location - About 2 hrs to fix
lib/qasim/map/ssh.rb on lines 51..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method action_trigger_map_item has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

        def action_trigger_map_item map, item
            @connect_error[map.filename] = Set.new
            @connect_running[map.filename] = 0
            method = if map.mounted? then :umount
                     else :mount
Severity: Minor
Found in lib/qasim/gui.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method from_file has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def from_file appcfg, filename
    params = {
      type: :ssh  # for params V1, we assume SSHFS by default
    }
    map = nil
Severity: Minor
Found in lib/qasim/map.rb - About 1 hr to fix

    Method parse_maps has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def parse_maps &blk
        @maps = []
        map_dirs = [@config.config_dir, Qasim::APP_SYSCONFIG_DIR].select do |d|
            File.exist? d and File.directory? d 
    end
    Severity: Minor
    Found in lib/qasim/map_manager.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method action_trigger_map_item has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def action_trigger_map_item map, item
            @connect_error[map.filename] = Set.new
            @connect_running[map.filename] = 0
            method = if map.mounted? then :umount
                     else :mount
    Severity: Minor
    Found in lib/qasim/gui.rb - About 1 hr to fix

      Method initialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def initialize(parent = nil)
            super
            @ui = Ui_About.new                                                                                                    
            @ui.setup_ui(self)
      Severity: Minor
      Found in lib/qasim/ui/about.rb - About 1 hr to fix

        Method lock_set has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

                def lock_set
            begin
                # create an exclusive lock file
                _have_lock = true
        Severity: Minor
        Found in lib/qasim/gui.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method from_file has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def from_file appcfg, filename
    params = {
      type: :ssh  # for params V1, we assume SSHFS by default
    }
    map = nil
        Severity: Minor
        Found in lib/qasim/map.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method umount has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def umount &block
        @links.each do |name, remotepath|
            localpath = File.join ENV['HOME'], "mnt", name
            cmd = "fusermount"
            cmd_args = [
        Severity: Minor
        Found in lib/qasim/map/generic.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method env_substitute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def env_substitute text
    seek = true
    str = text

        while seek do
        Severity: Minor
        Found in lib/qasim/map.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method mount has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def mount &block
        @links.each do |name, remotepath|
            mount_link(name, remotepath)
            if block_given? then
                yield name, cmd, cmd_args
        Severity: Minor
        Found in lib/qasim/map/generic.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language