glitch-soc/mastodon

View on GitHub
app/javascript/mastodon/features/emoji/emoji_utils.js

Summary

Maintainability
F
1 wk
Test Coverage

Function getData has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

function getData(emoji, skin, set) {
  let emojiData = {};

  if (typeof emoji === 'string') {
    let matches = emoji.match(COLONS_REGEX);
Severity: Minor
Found in app/javascript/mastodon/features/emoji/emoji_utils.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getData has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getData(emoji, skin, set) {
  let emojiData = {};

  if (typeof emoji === 'string') {
    let matches = emoji.match(COLONS_REGEX);
Severity: Major
Found in app/javascript/mastodon/features/emoji/emoji_utils.js - About 2 hrs to fix

    Function stringFromCodePoint has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const stringFromCodePoint = _String.fromCodePoint || function () {
      let MAX_SIZE = 0x4000;
      let codeUnits = [];
      let highSurrogate;
      let lowSurrogate;
    Severity: Minor
    Found in app/javascript/mastodon/features/emoji/emoji_utils.js - About 1 hr to fix

      Function buildSearch has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      const buildSearch = (data) => {
        const search = [];
      
        let addToSearch = (strings, split) => {
          if (!strings) {
      Severity: Minor
      Found in app/javascript/mastodon/features/emoji/emoji_utils.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function stringFromCodePoint has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      const stringFromCodePoint = _String.fromCodePoint || function () {
        let MAX_SIZE = 0x4000;
        let codeUnits = [];
        let highSurrogate;
        let lowSurrogate;
      Severity: Minor
      Found in app/javascript/mastodon/features/emoji/emoji_utils.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function deepMerge has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function deepMerge(a, b) {
        let o = {};
      
        for (let key in a) {
          let originalValue = a[key],
      Severity: Minor
      Found in app/javascript/mastodon/features/emoji/emoji_utils.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function getData(emoji, skin, set) {
        let emojiData = {};
      
        if (typeof emoji === 'string') {
          let matches = emoji.match(COLONS_REGEX);
      Severity: Major
      Found in app/javascript/mastodon/features/emoji/emoji_utils.js and 1 other location - About 3 days to fix
      app/javascript/flavours/glitch/features/emoji/emoji_utils.js on lines 124..194

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 626.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      const stringFromCodePoint = _String.fromCodePoint || function () {
        let MAX_SIZE = 0x4000;
        let codeUnits = [];
        let highSurrogate;
        let lowSurrogate;
      Severity: Major
      Found in app/javascript/mastodon/features/emoji/emoji_utils.js and 1 other location - About 1 day to fix
      app/javascript/flavours/glitch/features/emoji/emoji_utils.js on lines 35..71

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 319.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      const buildSearch = (data) => {
        const search = [];
      
        let addToSearch = (strings, split) => {
          if (!strings) {
      Severity: Major
      Found in app/javascript/mastodon/features/emoji/emoji_utils.js and 1 other location - About 1 day to fix
      app/javascript/flavours/glitch/features/emoji/emoji_utils.js on lines 6..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 216.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function sanitize(emoji) {
        let { name, short_names, skin_tone, skin_variations, emoticons, unified, custom, imageUrl } = emoji,
          id = emoji.id || short_names[0],
          colons = `:${id}:`;
      
      
      Severity: Major
      Found in app/javascript/mastodon/features/emoji/emoji_utils.js and 1 other location - About 1 day to fix
      app/javascript/flavours/glitch/features/emoji/emoji_utils.js on lines 89..118

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 212.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function measureScrollbar() {
        const div = document.createElement('div');
      
        div.style.width = '100px';
        div.style.height = '100px';
      Severity: Major
      Found in app/javascript/mastodon/features/emoji/emoji_utils.js and 1 other location - About 5 hrs to fix
      app/javascript/flavours/glitch/features/emoji/emoji_utils.js on lines 234..248

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 152.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function deepMerge(a, b) {
        let o = {};
      
        for (let key in a) {
          let originalValue = a[key],
      Severity: Major
      Found in app/javascript/mastodon/features/emoji/emoji_utils.js and 1 other location - About 4 hrs to fix
      app/javascript/flavours/glitch/features/emoji/emoji_utils.js on lines 212..231

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 115.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function uniq(arr) {
        return arr.reduce((acc, item) => {
          if (acc.indexOf(item) === -1) {
            acc.push(item);
          }
      Severity: Major
      Found in app/javascript/mastodon/features/emoji/emoji_utils.js and 1 other location - About 1 hr to fix
      app/javascript/flavours/glitch/features/emoji/emoji_utils.js on lines 196..203

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function unifiedToNative(unified) {
        let unicodes = unified.split('-'),
          codePoints = unicodes.map((u) => `0x${u}`);
      
        return stringFromCodePoint.apply(null, codePoints);
      Severity: Major
      Found in app/javascript/mastodon/features/emoji/emoji_utils.js and 1 other location - About 1 hr to fix
      app/javascript/flavours/glitch/features/emoji/emoji_utils.js on lines 82..87

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function intersect(a, b) {
        const uniqA = uniq(a);
        const uniqB = uniq(b);
      
        return uniqA.filter(item => uniqB.indexOf(item) >= 0);
      Severity: Major
      Found in app/javascript/mastodon/features/emoji/emoji_utils.js and 1 other location - About 1 hr to fix
      app/javascript/flavours/glitch/features/emoji/emoji_utils.js on lines 205..210

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status