glittergallery/GlitterGallery

View on GitHub
app/controllers/projects_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

File projects_controller.rb has 343 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class ProjectsController < ApplicationController
  before_filter :store_return_to

  before_filter :return_context, except: [:new,
                                          :create,
Severity: Minor
Found in app/controllers/projects_controller.rb - About 4 hrs to fix

    Class ProjectsController has 31 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class ProjectsController < ApplicationController
      before_filter :store_return_to
    
      before_filter :return_context, except: [:new,
                                              :create,
    Severity: Minor
    Found in app/controllers/projects_controller.rb - About 3 hrs to fix

      Method create_directory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def create_directory
          if params[:directory].empty?
            flash[:alert] = 'No name provided for the directory!'
            redirect_to :back
          else
      Severity: Minor
      Found in app/controllers/projects_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method file_upload has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def file_upload
          branch = params[:branch] || 'master'
          if params[:file]
            if user_signed_in? && @project.add_images(
              branch,
      Severity: Minor
      Found in app/controllers/projects_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def create
          @project = Project.new project_params
          @project.user_id = current_user.id
          @project.private = true if params[:commit] == 'Private'
          if @project.save
      Severity: Minor
      Found in app/controllers/projects_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status