glittergallery/GlitterGallery

View on GitHub
app/models/project.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Project has 40 methods (exceeds 20 allowed). Consider refactoring.
Open

class Project < ActiveRecord::Base

  include Sortable
  after_create :set_path, :init, :add_tags
  after_destroy :deletefiles
Severity: Minor
Found in app/models/project.rb - About 5 hrs to fix

    File project.rb has 328 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Project < ActiveRecord::Base
    
      include Sortable
      after_create :set_path, :init, :add_tags
      after_destroy :deletefiles
    Severity: Minor
    Found in app/models/project.rb - About 3 hrs to fix

      Method update_image has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def update_image(branch, old_path, new_file, author, message)
      Severity: Minor
      Found in app/models/project.rb - About 35 mins to fix

        Method get_object has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_object(type, id)
            repo = barerepo
            return false if repo.empty?
            return repo.head.target unless id
            begin
        Severity: Minor
        Found in app/models/project.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method branch_tree has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def branch_tree(id, destination = nil)
            res = branch_commit id
            return nil unless res
            return res.tree unless destination
            begin
        Severity: Minor
        Found in app/models/project.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status