Sign upLogin

glnster/hex2rgb

View on GitHub
Star

Showing 9 of 9 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

var hex2rgb = function(hex, options) {
  'use strict';

  // checks and defaults
  if (typeof hex !== 'string') {
Severity: Major
Found in hex2rgb.js and 1 other location - About 2 days to fix
index.js on lines 21..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 505.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

var hex2rgb = function(hex, options) {
  'use strict';

  // checks and defaults
  if (typeof hex !== 'string') {
Severity: Major
Found in index.js and 1 other location - About 2 days to fix
hex2rgb.js on lines 21..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 505.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function addSorting has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

var addSorting = (function () {
    "use strict";
    var cols,
        currentSort = {
            index: 0,
Severity: Minor
Found in coverage/lcov-report/sorter.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addSorting has 127 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var addSorting = (function () {
    "use strict";
    var cols,
        currentSort = {
            index: 0,
Severity: Major
Found in coverage/lcov-report/sorter.js - About 5 hrs to fix

    Function hex2rgb has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    var hex2rgb = function(hex, options) {
  'use strict';

  // checks and defaults
  if (typeof hex !== 'string') {
    Severity: Minor
    Found in hex2rgb.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function hex2rgb has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    var hex2rgb = function(hex, options) {
  'use strict';

  // checks and defaults
  if (typeof hex !== 'string') {
    Severity: Minor
    Found in index.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function hex2rgb has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var hex2rgb = function(hex, options) {
  'use strict';

  // checks and defaults
  if (typeof hex !== 'string') {
    Severity: Minor
    Found in index.js - About 1 hr to fix

      Function hex2rgb has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var hex2rgb = function(hex, options) {
  'use strict';

  // checks and defaults
  if (typeof hex !== 'string') {
      Severity: Minor
      Found in hex2rgb.js - About 1 hr to fix

        Function enableUI has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function enableUI() {
        var i,
            el,
            ithSorter = function ithSorter(i) {
                var col = cols[i];
        Severity: Minor
        Found in coverage/lcov-report/sorter.js - About 1 hr to fix
          Severity
          Category
          Status
          Source
          Language