globalreachtech/tinyradius-netty

RadiusAttribute has 22 methods (exceeds 20 allowed). Consider refactoring.

Open

public interface RadiusAttribute {
 
    /**
     * @return vendor Id if Vendor-Specific attribute or sub-attribute, otherwise -1
     */

AttributeHolder has 22 methods (exceeds 20 allowed). Consider refactoring.

Open

public interface AttributeHolder<T extends AttributeHolder<T>> {
 
    Logger attrHolderLogger = LogManager.getLogger();
 
    static ByteBuf attributesToBytes(List<RadiusAttribute> attributes) {

Method parseTokens has 41 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private void parseTokens(String[] tokens, int lineNum, String resource) throws IOException {
        switch (tokens[0].toUpperCase()) {
            case "END-VENDOR":
                parseEndVendor(tokens, lineNum);
                break;

Method readAttribute has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    static RadiusAttribute readAttribute(Dictionary dictionary, int vendorId, ByteBuf data) {
        final Optional<Vendor> vendor = dictionary.getVendor(vendorId);
 
        final int typeSize = vendor
                .map(Vendor::getTypeSize)

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (!Arrays.equals(messageAuth, computeMessageAuth(this, sharedSecret, requestAuth))) {
            // find attributes that should be encoded but aren't
            final boolean decodedAlready = getAttributes().stream()
                    .filter(a -> a.getAttributeTemplate()
                            .map(AttributeTemplate::isEncrypt)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (!Arrays.equals(expectedAuth, auth)) {
            // find attributes that should be encoded but aren't
            final boolean decodedAlready = getAttributes().stream()
                    .filter(a -> a.getAttributeTemplate()
                            .map(AttributeTemplate::isEncrypt)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    static RadiusRequest create(Dictionary dictionary, byte type, byte id, byte[] authenticator, List<RadiusAttribute> attributes) throws RadiusPacketException {
        List<RadiusAttribute> wrappedAttributes = attributes.stream()
                .map(NestedAttributeHolder::vsaAutowrap)
                .collect(toList());
        final ByteBuf header = RadiusPacket.buildHeader(type, id, authenticator, wrappedAttributes);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    static RadiusResponse create(Dictionary dictionary, byte type, byte id, byte[] authenticator, List<RadiusAttribute> attributes) throws RadiusPacketException {
        List<RadiusAttribute> wrappedAttributes = attributes.stream()
                .map(NestedAttributeHolder::vsaAutowrap)
                .collect(toList());
        final ByteBuf header = RadiusPacket.buildHeader(type, id, authenticator, wrappedAttributes);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public AccountingRequest(Dictionary dictionary, ByteBuf header, List<RadiusAttribute> attributes) throws RadiusPacketException {
        super(dictionary, header, attributes);
        final byte type = header.getByte(0);
        if (type != ACCOUNTING_REQUEST)
            throw new IllegalArgumentException("First octet must be " + ACCOUNTING_REQUEST + ", actual: " + type);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    protected AccessRequest(Dictionary dictionary, ByteBuf header, List<RadiusAttribute> attributes) throws RadiusPacketException {
        super(dictionary, header, attributes);
        final byte type = header.getByte(0);
        if (type != ACCESS_REQUEST)
            throw new IllegalArgumentException("First octet must be " + ACCESS_REQUEST + ", actual: " + type);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    default RadiusAttribute createAttribute(int vendorId, int type, byte tag, byte[] value) {
        return getAttributeTemplate(vendorId, type)
                .map(at -> at.create(this, tag, value))
                .orElseGet(() -> OctetsAttribute.FACTORY.create(this, vendorId, type, tag, value));
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    default RadiusAttribute createAttribute(int vendorId, int type, byte tag, String value) {
        return getAttributeTemplate(vendorId, type)
                .map(at -> at.create(this, tag, value))
                .orElseGet(() -> OctetsAttribute.FACTORY.create(this, vendorId, type, tag, value));
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        try {
            return create(attribute.getDictionary(), attribute.getTag().orElse((byte) 0),
                    codecType.getCodec().decode(attribute.getValue(), requestAuth, secret));
        } catch (Exception e) {
            throw new RadiusPacketException("Error decoding attribute " + attribute, e);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        try {
            return createEncoded(attribute.getDictionary(), attribute.getTag().orElse((byte) 0),
                    codecType.getCodec().encode(attribute.getValue(), requestAuth, secret));
        } catch (Exception e) {
            throw new RadiusPacketException("Error encoding attribute " + attribute, e);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        for (int i = 0; i < str.length; i += 16) {
            c = xor16(str, i, md5(secret, c));
            buffer.put(c);
        }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        for (int i = 0; i < plaintext.length; i += 16) {
            c = xor16(plaintext, i, md5(secret, c));
            buffer.put(c);
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    default List<RadiusAttribute> encodeAttributes(byte[] requestAuth, String sharedSecret) throws RadiusPacketException {
        final List<RadiusAttribute> encoded = new ArrayList<>();
        for (RadiusAttribute a : getAttributes()) {
            RadiusAttribute encode = a.encode(requestAuth, sharedSecret);
            encoded.add(encode);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    default List<RadiusAttribute> decodeAttributes(byte[] requestAuth, String sharedSecret) throws RadiusPacketException {
        final List<RadiusAttribute> decoded = new ArrayList<>();
        for (RadiusAttribute a : getAttributes()) {
            RadiusAttribute decode = a.decode(requestAuth, sharedSecret);
            decoded.add(decode);

• Read up
  Read up

Method communicateRecursive has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    private void communicateRecursive(RadiusRequest packet, List<RadiusEndpoint> endpoints, int endpointIndex,
                                      Promise<RadiusResponse> promise, Throwable lastException) {

Method create has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    static RadiusResponse create(Dictionary dictionary, byte type, byte id, byte[] authenticator, List<RadiusAttribute> attributes) throws RadiusPacketException {