queries/session.py

Summary

Maintainability
C
1 day
Test Coverage

File session.py has 285 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""The Session class allows for a unified (and simplified) view of
interfacing with a PostgreSQL database server.

Connection details are passed in as a PostgreSQL URI and connections are pooled
by default, allowing for reuse of connections across modules in the Python
Severity: Minor
Found in queries/session.py - About 2 hrs to fix

    Session has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Session(object):
        """The Session class allows for a unified (and simplified) view of
        interfacing with a PostgreSQL database server. The Session object can
        act as a context manager, providing automated cleanup and simple, Pythonic
        way of interacting with the object.
    Severity: Minor
    Found in queries/session.py - About 2 hrs to fix

      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, uri=DEFAULT_URI,
      Severity: Minor
      Found in queries/session.py - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def callproc(self, name, args=None):
                """Call a stored procedure on the server, returning the results in a
                :py:class:`queries.Results` instance.
        
                :param str name: The procedure name
        Severity: Major
        Found in queries/session.py and 1 other location - About 3 hrs to fix
        queries/session.py on lines 194..220

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 67.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def query(self, sql, parameters=None):
                """A generator to issue a query on the server, mogrifying the
                parameters against the sql statement. Results are returned as a
                :py:class:`queries.Results` object which can act as an iterator and
                has multiple ways to access the result data.
        Severity: Major
        Found in queries/session.py and 1 other location - About 3 hrs to fix
        queries/session.py on lines 106..130

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 67.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status