Sign upLogin

go-auth0/auth0

View on GitHub
Star
management/branding.go

Summary

Maintainability
B
5 hrs
Test Coverage
B
80%

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (bc *BrandingColors) UnmarshalJSON(data []byte) error {

    type brandingColors BrandingColors
    type brandingColorsWrapper struct {
        *brandingColors
Severity: Major
Found in management/branding.go and 1 other location - About 3 hrs to fix
management/tenant.go on lines 250..291

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 289.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (bc *BrandingColors) MarshalJSON() ([]byte, error) {
    type brandingColors BrandingColors
    type brandingColorsWrapper struct {
        *brandingColors
        RawPageBackground interface{} `json:"page_background,omitempty"`
Severity: Major
Found in management/branding.go and 1 other location - About 1 hr to fix
management/tenant.go on lines 226..244

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 163.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

exported type BrandingPageBackgroundGradient should have comment or be unexported
Open

type BrandingPageBackgroundGradient struct {
Severity: Minor
Found in management/branding.go by golint

comment on exported method BrandingManager.UniversalLogin should be of the form "UniversalLogin ..."
Open

// Retrieve template for New Universal Login Experience.
Severity: Minor
Found in management/branding.go by golint

exported type BrandingUniversalLogin should have comment or be unexported
Open

type BrandingUniversalLogin struct {
Severity: Minor
Found in management/branding.go by golint

exported type Branding should have comment or be unexported
Open

type Branding struct {
Severity: Minor
Found in management/branding.go by golint

comment on exported method BrandingManager.SetUniversalLogin should be of the form "SetUniversalLogin ..."
Open

// Set template for the New Universal Login Experience.
Severity: Minor
Found in management/branding.go by golint

exported type BrandingManager should have comment or be unexported
Open

type BrandingManager struct {
Severity: Minor
Found in management/branding.go by golint

comment on exported method BrandingManager.DeleteUniversalLogin should be of the form "DeleteUniversalLogin ..."
Open

// Delete template for New Universal Login Experience.
Severity: Minor
Found in management/branding.go by golint

exported type BrandingColors should have comment or be unexported
Open

type BrandingColors struct {
Severity: Minor
Found in management/branding.go by golint

exported type BrandingFont should have comment or be unexported
Open

type BrandingFont struct {
Severity: Minor
Found in management/branding.go by golint

There are no issues that match your filters.

Category
Status