go-auth0/auth0

View on GitHub
management/management.go

Summary

Maintainability
A
3 hrs
Test Coverage
B
83%

Function New has 51 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func New(domain string, options ...ManagementOption) (*Management, error) {

    // Ignore the scheme if it was defined in the domain variable. Then prefix
    // with https as its the only scheme supported by the Auth0 API.
    if i := strings.Index(domain, "//"); i != -1 {
Severity: Minor
Found in management/management.go - About 1 hr to fix

    Method Management.Request has 6 return statements (exceeds 4 allowed).
    Open

    func (m *Management) Request(method, uri string, v interface{}, options ...RequestOption) error {
    
        req, err := m.NewRequest(method, uri, v, options...)
        if err != nil {
            return err
    Severity: Major
    Found in management/management.go - About 40 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func IncludeFields(fields ...string) RequestOption {
          return newRequestOption(func(r *http.Request) {
              q := r.URL.Query()
              q.Set("fields", strings.Join(fields, ","))
              q.Set("include_fields", "true")
      Severity: Minor
      Found in management/management.go and 1 other location - About 50 mins to fix
      management/management.go on lines 435..442

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func ExcludeFields(fields ...string) RequestOption {
          return newRequestOption(func(r *http.Request) {
              q := r.URL.Query()
              q.Set("fields", strings.Join(fields, ","))
              q.Set("include_fields", "false")
      Severity: Minor
      Found in management/management.go and 1 other location - About 50 mins to fix
      management/management.go on lines 425..432

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Your code does not pass gofmt in 2 places. Go fmt your code!
      Open

      package management
      Severity: Minor
      Found in management/management.go by gofmt

      comment on exported function WithContext should be of the form "WithContext ..."
      Open

      // WitContext configures the management client to use the provided context
      Severity: Minor
      Found in management/management.go by golint

      type name will be used as management.ManagementOption by other packages, and that stutters; consider calling this Option
      Open

      type ManagementOption func(*Management)
      Severity: Minor
      Found in management/management.go by golint

      exported type ManagementOption should have comment or be unexported
      Open

      type ManagementOption func(*Management)
      Severity: Minor
      Found in management/management.go by golint

      exported method List.HasNext should have comment or be unexported
      Open

      func (l List) HasNext() bool {
      Severity: Minor
      Found in management/management.go by golint

      There are no issues that match your filters.

      Category
      Status