Sign upLogin

go-auth0/auth0

View on GitHub
Star
management/role.go

Summary

Maintainability
A
2 hrs
Test Coverage
A
100%

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func (m *RoleManager) AssignUsers(id string, users []*User, opts ...RequestOption) error {
    u := make(map[string][]*string)
    u["users"] = make([]*string, len(users))
    for i, user := range users {
        u["users"][i] = user.ID
Severity: Major
Found in management/role.go and 2 other locations - About 1 hr to fix
management/user.go on lines 385..392
management/user.go on lines 397..404

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 146.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func (m *RoleManager) AssociatePermissions(id string, permissions []*Permission, opts ...RequestOption) error {
    p := make(map[string][]*Permission)
    p["permissions"] = permissions
    return m.Request("POST", m.URI("roles", id, "permissions"), &p, opts...)
}
Severity: Major
Found in management/role.go and 3 other locations - About 35 mins to fix
management/role.go on lines 127..131
management/user.go on lines 417..421
management/user.go on lines 426..430

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func (m *RoleManager) RemovePermissions(id string, permissions []*Permission, opts ...RequestOption) error {
    p := make(map[string][]*Permission)
    p["permissions"] = permissions
    return m.Request("DELETE", m.URI("roles", id, "permissions"), &p, opts...)
}
Severity: Major
Found in management/role.go and 3 other locations - About 35 mins to fix
management/role.go on lines 110..114
management/user.go on lines 417..421
management/user.go on lines 426..430

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

exported type PermissionList should have comment or be unexported
Open

type PermissionList struct {
Severity: Minor
Found in management/role.go by golint

exported type RoleManager should have comment or be unexported
Open

type RoleManager struct {
Severity: Minor
Found in management/role.go by golint

exported type Permission should have comment or be unexported
Open

type Permission struct {
Severity: Minor
Found in management/role.go by golint

exported type Role should have comment or be unexported
Open

type Role struct {
Severity: Minor
Found in management/role.go by golint

exported type RoleList should have comment or be unexported
Open

type RoleList struct {
Severity: Minor
Found in management/role.go by golint

There are no issues that match your filters.

Category
Status