Sign upLogin

gobuffalo/velvet

View on GitHub
Star

Showing 10 of 10 total issues

Method evalVisitor.VisitPath has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
Open

func (ev *evalVisitor) VisitPath(node *ast.PathExpression) interface{} {
    // fmt.Println("VisitPath")
    // fmt.Printf("### node -> %+v\n", node)
    // fmt.Printf("### node -> %T\n", node)
    // fmt.Printf("### node.IsDataRoot() -> %+v\n", node.IsDataRoot())
Severity: Minor
Found in eval.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method evalVisitor.VisitPath has 63 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (ev *evalVisitor) VisitPath(node *ast.PathExpression) interface{} {
    // fmt.Println("VisitPath")
    // fmt.Printf("### node -> %+v\n", node)
    // fmt.Printf("### node -> %T\n", node)
    // fmt.Printf("### node.IsDataRoot() -> %+v\n", node.IsDataRoot())
Severity: Minor
Found in eval.go - About 1 hr to fix

    Method evalVisitor.evalHelper has 54 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (ev *evalVisitor) evalHelper(node *ast.Expression, helper interface{}) (ret interface{}) {
    // fmt.Println("evalHelper")
    defer func() {
        if r := recover(); r != nil {
            switch rp := r.(type) {
    Severity: Minor
    Found in eval.go - About 1 hr to fix

      Method evalVisitor.evalHelper has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
      Open

      func (ev *evalVisitor) evalHelper(node *ast.Expression, helper interface{}) (ret interface{}) {
    // fmt.Println("evalHelper")
    defer func() {
        if r := recover(); r != nil {
            switch rp := r.(type) {
      Severity: Minor
      Found in eval.go - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func equalHelper(a, b interface{}, help HelperContext) (template.HTML, error) {
    if a == b {
        s, err := help.Block()
        if err != nil {
            return "", err
      Severity: Minor
      Found in equal_helper.go and 1 other location - About 55 mins to fix
      equal_helper.go on lines 20..33

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 123.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func notEqualHelper(a, b interface{}, help HelperContext) (template.HTML, error) {
    if a != b {
        s, err := help.Block()
        if err != nil {
            return "", err
      Severity: Minor
      Found in equal_helper.go and 1 other location - About 55 mins to fix
      equal_helper.go on lines 5..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 123.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method evalVisitor.VisitExpression has 8 return statements (exceeds 4 allowed).
      Open

      func (ev *evalVisitor) VisitExpression(e *ast.Expression) interface{} {
    // fmt.Println("VisitExpression")
    if e.Hash != nil {
        e.Hash.Accept(ev)
    }
      Severity: Major
      Found in eval.go - About 50 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        } else if last.Kind() == reflect.Map {
                    args = append(args, reflect.ValueOf(ev.context.Options()))
                }
        Severity: Major
        Found in eval.go - About 45 mins to fix

          Method evalVisitor.VisitPath has 5 return statements (exceeds 4 allowed).
          Open

          func (ev *evalVisitor) VisitPath(node *ast.PathExpression) interface{} {
    // fmt.Println("VisitPath")
    // fmt.Printf("### node -> %+v\n", node)
    // fmt.Printf("### node -> %T\n", node)
    // fmt.Printf("### node.IsDataRoot() -> %+v\n", node.IsDataRoot())
          Severity: Major
          Found in eval.go - About 35 mins to fix

            2: cannot find package "github.com/pkg/errors" in any of:
            Open

                "github.com/pkg/errors"
            Severity: Minor
            Found in content_helper.go by govet
            Severity
            Category
            Status
            Source
            Language