Sign upLogin

gocodebox/lifterlms-rest

View on GitHub
Star
includes/server/class-llms-rest-lessons-controller.php

Summary

Maintainability
F
3 days
Test Coverage
A
95%

File class-llms-rest-lessons-controller.php has 420 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * REST Lessons Controller
 *
 * @package LifterLMS_REST/Classes/Controllers
Severity: Minor
Found in includes/server/class-llms-rest-lessons-controller.php - About 6 hrs to fix

    Method get_item_schema_base has 147 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function get_item_schema_base() {

        $schema = (array) parent::get_item_schema_base();

        $lesson_properties = array(
    Severity: Major
    Found in includes/server/class-llms-rest-lessons-controller.php - About 5 hrs to fix

      Function prepare_item_for_database has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function prepare_item_for_database( $request ) {

        $prepared_item = parent::prepare_item_for_database( $request );
        $schema        = $this->get_item_schema();
      Severity: Minor
      Found in includes/server/class-llms-rest-lessons-controller.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method prepare_item_for_database has 67 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function prepare_item_for_database( $request ) {

        $prepared_item = parent::prepare_item_for_database( $request );
        $schema        = $this->get_item_schema();
      Severity: Major
      Found in includes/server/class-llms-rest-lessons-controller.php - About 2 hrs to fix

        Method prepare_links has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function prepare_links( $lesson, $request ) {

        $links = parent::prepare_links( $lesson, $request );

        unset( $links['content'] );
        Severity: Minor
        Found in includes/server/class-llms-rest-lessons-controller.php - About 1 hr to fix

          Method prepare_collection_query_args has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function prepare_collection_query_args( $request ) {

        $query_args = parent::prepare_collection_query_args( $request );
        if ( is_wp_error( $query_args ) ) {
            return $query_args;
          Severity: Minor
          Found in includes/server/class-llms-rest-lessons-controller.php - About 1 hr to fix

            Method prepare_object_for_response has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function prepare_object_for_response( $lesson, $request ) {

        $data = parent::prepare_object_for_response( $lesson, $request );

        // Audio Embed.
            Severity: Minor
            Found in includes/server/class-llms-rest-lessons-controller.php - About 1 hr to fix

              Function update_additional_object_fields has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function update_additional_object_fields( $lesson, $request, $schema, $prepared_item, $creating = true ) {

        $error = new WP_Error();

        $to_set = array();
              Severity: Minor
              Found in includes/server/class-llms-rest-lessons-controller.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method update_additional_object_fields has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  protected function update_additional_object_fields( $lesson, $request, $schema, $prepared_item, $creating = true ) {
              Severity: Minor
              Found in includes/server/class-llms-rest-lessons-controller.php - About 35 mins to fix

                Function prepare_collection_query_args has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function prepare_collection_query_args( $request ) {

        $query_args = parent::prepare_collection_query_args( $request );
        if ( is_wp_error( $query_args ) ) {
            return $query_args;
                Severity: Minor
                Found in includes/server/class-llms-rest-lessons-controller.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    protected function prepare_collection_query_args( $request ) {

        $query_args = parent::prepare_collection_query_args( $request );
        if ( is_wp_error( $query_args ) ) {
            return $query_args;
                Severity: Major
                Found in includes/server/class-llms-rest-lessons-controller.php and 1 other location - About 5 hrs to fix
                includes/server/class-llms-rest-sections-controller.php on lines 368..409

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 196.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ( ! empty( $schema['properties']['course_id'] ) && isset( $request['course_id'] ) ) {

            $parent_course = llms_get_post( $request['course_id'] );

            if ( ! $parent_course || ! is_a( $parent_course, 'LLMS_Course' ) ) {
                Severity: Major
                Found in includes/server/class-llms-rest-lessons-controller.php and 1 other location - About 1 hr to fix
                includes/server/class-llms-rest-sections-controller.php on lines 205..214

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 103.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status