File _Editable.js
has 327 lines of code (exceeds 250 allowed). Consider refactoring. Open
/**
* Handles UX and Events for inline editing of views
*
* Use with a Model's View
* Allows editing model.title field via .llms-editable-title elements
Function is_valid
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
is_valid: function( event ) {
var self = this,
$el = $( event.target ),
content = this.get_content( $el ),
Function init_formatting_els
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
init_formatting_els: function() {
var self = this;
this.$el.find( '.llms-input-formatting[data-formatting]' ).each( function() {
Function open_media_lib
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
open_media_lib: function( event ) {
event.stopPropagation();
var self = this,
Function toggle_switch
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
toggle_switch: function( event ) {
event.stopPropagation();
var $el = $( event.target ),
attr = $el.attr( 'name' ),
Identical blocks of code found in 2 locations. Consider refactoring. Open
$ed.on( 'input', function( event ) {
self.model.set( prop, $ed.val() );
} );
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 45.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76