Sign upLogin

gocodebox/lifterlms

View on GitHub
Star
includes/abstracts/llms.abstract.notification.view.php

Summary

Maintainability
D
1 day
Test Coverage
F
56%

LLMS_Abstract_Notification_View has 38 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class LLMS_Abstract_Notification_View extends LLMS_Abstract_Options_Data {

    /**
     * Settings for basic notifications
     *
Severity: Minor
Found in includes/abstracts/llms.abstract.notification.view.php - About 5 hrs to fix

    File llms.abstract.notification.view.php has 326 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Notification View Abstract
 *
 * @package LifterLMS/Abstracts/Classes
    Severity: Minor
    Found in includes/abstracts/llms.abstract.notification.view.php - About 3 hrs to fix

      Method get_field_options has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function get_field_options( $type ) {

        $options = array();

        if ( $this->has_field_support( $type, 'subject' ) ) {
      Severity: Minor
      Found in includes/abstracts/llms.abstract.notification.view.php - About 1 hr to fix

        Method get_basic_html has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function get_basic_html() {

        // Setup html classes.
        $classes = array(
            'llms-notification',
        Severity: Minor
        Found in includes/abstracts/llms.abstract.notification.view.php - About 1 hr to fix

          Function get_merged_string has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function get_merged_string( $string ) {

        // Only merge if there are codes in the string.
        if ( false !== strpos( $string, '{{' ) ) {
          Severity: Minor
          Found in includes/abstracts/llms.abstract.notification.view.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function get_subject( $merge = true ) {
        $subject = $this->get_option( 'subject', apply_filters( $this->get_filter( 'set_subject' ), $this->set_subject(), $this ) );
        if ( $merge ) {
            $subject = $this->get_merged_string( $subject );
        }
          Severity: Minor
          Found in includes/abstracts/llms.abstract.notification.view.php and 1 other location - About 30 mins to fix
          includes/abstracts/llms.abstract.notification.view.php on lines 716..722

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 91.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function get_title( $merge = true ) {
        $title = $this->get_option( 'title', apply_filters( $this->get_filter( 'set_title' ), $this->set_title(), $this ) );
        if ( $merge ) {
            $title = $this->get_merged_string( $title );
        }
          Severity: Minor
          Found in includes/abstracts/llms.abstract.notification.view.php and 1 other location - About 30 mins to fix
          includes/abstracts/llms.abstract.notification.view.php on lines 690..696

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 91.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status