gocodebox/lifterlms

View on GitHub
includes/admin/post-types/meta-boxes/class-llms-meta-box-achievement-sync.php

Summary

Maintainability
D
2 days
Test Coverage
C
73%

Method get_text has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function get_text( $text_type, $variables = array() ) {

        switch ( $text_type ) {
            case self::TEXT_SYNC_ALERT_MANY_AWARDED_ENGAGEMENTS:
                return sprintf(

    Avoid too many return statements within this method.
    Open

                    return sprintf(
                        /* translators: %1$s: link to edit the achievement template, %2$s: closing anchor tag */
                        __( 'Sync this awarded achievement with its %1$sachievement template%2$s.', 'lifterlms' ),
                        '<a href="' . get_edit_post_link( ( $variables['template_id'] ?? 0 ) ) . '" target="_blank">',
                        '</a>'

      Avoid too many return statements within this method.
      Open

                      return parent::get_text( $text_type );

        Avoid too many return statements within this method.
        Open

                        return __( 'Sync Awarded Achievements', 'lifterlms' );

          Avoid too many return statements within this method.
          Open

                          return sprintf(
                              /* translators: %1$d: number of awarded achievements */
                              __( 'Sync %1$d awarded achievement with this achievement template.', 'lifterlms' ),
                              ( $variables['awarded_number'] ?? 0 )
                          );

            Avoid too many return statements within this method.
            Open

                            return __( 'This achievement template has no awarded achievements to sync.', 'lifterlms' );

              Avoid too many return statements within this method.
              Open

                              return __( 'Sync Awarded Achievement', 'lifterlms' );

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                <?php
                /**
                 * LLMS_Meta_Box_Achievement_Sync class
                 *
                 * @package LifterLMS/Admin/PostTypes/MetaBoxes/Classes
                includes/admin/post-types/meta-boxes/class-llms-meta-box-certificate-sync.php on lines 1..123

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 372.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status