Sign upLogin

gocodebox/lifterlms

View on GitHub
Star
includes/admin/reporting/tables/llms.table.course.students.php

Summary

Maintainability
D
2 days
Test Coverage
A
90%

Method get_results has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_results( $args = array() ) {

        $this->title = __( 'Students', 'lifterlms' );

        if ( ! $args ) {
Severity: Major
Found in includes/admin/reporting/tables/llms.table.course.students.php - About 2 hrs to fix

    Method get_data has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get_data( $key, $student ) {

        $value = '';

        switch ( $key ) {
    Severity: Major
    Found in includes/admin/reporting/tables/llms.table.course.students.php - About 2 hrs to fix

      Method set_columns has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function set_columns() {
        $cols = array(
            'id'          => array(
                'exportable' => true,
                'sortable'   => true,
      Severity: Major
      Found in includes/admin/reporting/tables/llms.table.course.students.php - About 2 hrs to fix

        Function get_data has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

            public function get_data( $key, $student ) {

        $value = '';

        switch ( $key ) {
        Severity: Minor
        Found in includes/admin/reporting/tables/llms.table.course.students.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File llms.table.course.students.php has 251 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
/**
 * Display students enrolled in a given course on the course students subtab
 *
 * @package LifterLMS/Admin/Reporting/Tables/Classes
        Severity: Minor
        Found in includes/admin/reporting/tables/llms.table.course.students.php - About 2 hrs to fix

          Function get_results has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function get_results( $args = array() ) {

        $this->title = __( 'Students', 'lifterlms' );

        if ( ! $args ) {
          Severity: Minor
          Found in includes/admin/reporting/tables/llms.table.course.students.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function get_export_data has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function get_export_data( $key, $student ) {

        switch ( $key ) {

            case 'id':
          Severity: Minor
          Found in includes/admin/reporting/tables/llms.table.course.students.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      case 'name':
                $first = $student->get( 'first_name' );
                $last  = $student->get( 'last_name' );

                if ( ! $first || ! $last ) {
          Severity: Major
          Found in includes/admin/reporting/tables/llms.table.course.students.php and 1 other location - About 3 hrs to fix
          includes/admin/reporting/tables/llms.table.membership.students.php on lines 141..163

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 160.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status