gocodebox/lifterlms

View on GitHub
includes/admin/settings/class.llms.settings.checkout.php

Summary

Maintainability
D
1 day
Test Coverage
C
73%

Method get_settings_default has 156 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function get_settings_default() {

        $currency_code_options = get_lifterlms_currencies();
        foreach ( $currency_code_options as $code => $name ) {
            $currency_code_options[ $code ] = $name . ' (' . get_lifterlms_currency_symbol( $code ) . ')';
Severity: Major
Found in includes/admin/settings/class.llms.settings.checkout.php - About 6 hrs to fix

    File class.llms.settings.checkout.php has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * Admin Settings Page, Checkout Tab
     *
     * @package LifterLMS/Admin/Settings/Classes
    Severity: Minor
    Found in includes/admin/settings/class.llms.settings.checkout.php - About 2 hrs to fix

      Method get_gateway_table_html has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function get_gateway_table_html() {
      
              $gateways = llms()->payment_gateways()->get_payment_gateways();
      
              usort( $gateways, array( $this, 'sort_gateways' ) );
      Severity: Minor
      Found in includes/admin/settings/class.llms.settings.checkout.php - About 1 hr to fix

        Method get_settings_gateway has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function get_settings_gateway( $curr_section ) {
        
                $settings = array();
        
                $settings[] = array(
        Severity: Minor
        Found in includes/admin/settings/class.llms.settings.checkout.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function __construct() {
          
                  $this->id    = 'checkout';
                  $this->label = __( 'Checkout', 'lifterlms' );
          
          
          Severity: Major
          Found in includes/admin/settings/class.llms.settings.checkout.php and 1 other location - About 2 hrs to fix
          includes/admin/settings/class.llms.settings.integrations.php on lines 30..40

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 133.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status