File class-llms-block-templates.php
has 298 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* LLMS_Block_Templates class file
*
* @package LifterLMS/Classes
LLMS_Block_Templates
has 21 functions (exceeds 20 allowed). Consider refactoring. Open
class LLMS_Block_Templates {
use LLMS_Trait_Singleton;
/**
Method block_templates_from_db
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function block_templates_from_db( $slugs = array() ) {
$query_args = array(
'post_status' => array( 'auto-draft', 'draft', 'publish' ),
'post_type' => 'wp_template',
Method build_template_result_from_post
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function build_template_result_from_post( $post ) {
$terms = get_the_terms( $post, 'wp_theme' );
if ( is_wp_error( $terms ) ) {
Avoid too many return
statements within this method. Open
return $template;
Similar blocks of code found in 2 locations. Consider refactoring. Open
return array(
'archive-course' => esc_html__( 'LifterLMS Course Catalog Template', 'lifterlms' ),
'archive-llms_membership' => esc_html__( 'LifterLMS Membership Catalog Template', 'lifterlms' ),
'single-certificate' => esc_html__( 'LifterLMS Certificate Template', 'lifterlms' ),
'single-no-access' => esc_html__( 'LifterLMS Single Template Access Restricted', 'lifterlms' ),
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 153.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76