gocodebox/lifterlms

View on GitHub
includes/controllers/class.llms.controller.achievements.php

Summary

Maintainability
B
6 hrs
Test Coverage
C
78%

Avoid too many return statements within this method.
Open

                return __( 'Sorry, you need to provide a valid achievement template ID.', 'lifterlms' );
Severity: Major
Found in includes/controllers/class.llms.controller.achievements.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return __( 'Sorry, you need to provide a valid awarded achievement ID.', 'lifterlms' );
    Severity: Major
    Found in includes/controllers/class.llms.controller.achievements.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return parent::get_text( $text_type );
      Severity: Major
      Found in includes/controllers/class.llms.controller.achievements.php - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            protected function get_text( $text_type, $variables = array() ) {
        
                switch ( $text_type ) {
                    case self::TEXT_SYNC_AWARDED_ENGAGEMENT_INSUFFICIENT_PERMISSIONS:
                        return sprintf(
        Severity: Major
        Found in includes/controllers/class.llms.controller.achievements.php and 1 other location - About 5 hrs to fix
        includes/controllers/class.llms.controller.certificates.php on lines 62..88

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 187.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status