gocodebox/lifterlms

View on GitHub
includes/functions/updates/llms-functions-updates-500.php

Summary

Maintainability
A
2 hrs
Test Coverage
A
100%

Method llms_update_500_add_admin_notice has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function llms_update_500_add_admin_notice() {

    require_once LLMS_PLUGIN_DIR . 'includes/admin/class.llms.admin.notices.php';

    $notice_id        = 'v500-welcome-msg';
Severity: Minor
Found in includes/functions/updates/llms-functions-updates-500.php - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        $html = sprintf(
            '<strong>%1$s</strong><br><br>%2$s<br><br>%3$s',
            __( 'Welcome to LifterLMS 5.0!', 'lifterlms' ),
            __( 'This new version of LifterLMS brings you the power to build and customize your student information forms using a simple point and click interface constructed on top of the WordPress block editor. Customization like the removal of default fields, changing the text of field labels, or reordering fields within a form is all possible without any code or professional help.', 'lifterlms' ),
            sprintf(
    Severity: Major
    Found in includes/functions/updates/llms-functions-updates-500.php and 1 other location - About 1 hr to fix
    includes/functions/updates/llms-functions-updates-600.php on lines 120..136

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status