Sign upLogin

goldsborough/ecstasy

View on GitHub
Star
ecstasy/parser.py

Summary

Maintainability
D
2 days
Test Coverage

File parser.py has 424 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-

"""
The heart of the ecstasy package, containing the main *Parser* class.
"""
Severity: Minor
Found in ecstasy/parser.py - About 6 hrs to fix

    Function stringify has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        def stringify(self, string, phrases, parent=None):

        """
        Stringifies phrases.
    Severity: Minor
    Found in ecstasy/parser.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_flags has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_flags(self, args):

        """
        Checks and retrieves positional and 'always' (keyword) flags
        from the many ways in which they may be passed to the
    Severity: Minor
    Found in ecstasy/parser.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parse has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        def parse(self, string, root=None):

        """
        Parses a string to handle escaped tags and retrieve phrases.
    Severity: Minor
    Found in ecstasy/parser.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self,
    Severity: Major
    Found in ecstasy/parser.py - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                              for i in key:
                            self.always[i] = value
                    else:
      Severity: Major
      Found in ecstasy/parser.py - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status