Sign upLogin

gomoob/php-metadata-extractor

View on GitHub
Star

Showing 22 of 22 total issues

Function addTagToDirectory has a Cognitive Complexity of 213 (exceeds 5 allowed). Consider refactoring.
Open

    private static function addTagToDirectory(Directory $directory, $tagLine)
    {
        $start = strpos($tagLine, '] ');
        
        if ($start === false) {
Severity: Minor
Found in src/main/php/Gomoob/MetadataExtractor/Imaging/ImageMetadataReader.php - About 4 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addTagToDirectory has 478 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function addTagToDirectory(Directory $directory, $tagLine)
    {
        $start = strpos($tagLine, '] ');
        
        if ($start === false) {
Severity: Major
Found in src/main/php/Gomoob/MetadataExtractor/Imaging/ImageMetadataReader.php - About 2 days to fix

    File ImageMetadataReader.php has 703 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * gomoob/php-metadata-extractor
 *
    Severity: Major
    Found in src/main/php/Gomoob/MetadataExtractor/Imaging/ImageMetadataReader.php - About 1 day to fix

      Function createDirectoryWithName has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function createDirectoryWithName($directoryName)
    {
        
        $directory = null;
      Severity: Minor
      Found in src/main/php/Gomoob/MetadataExtractor/Imaging/ImageMetadataReader.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exports has 134 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(grunt) {

    grunt.initConfig(
        {
      Severity: Major
      Found in Gruntfile.js - About 5 hrs to fix

        Method createDirectoryWithName has 111 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private static function createDirectoryWithName($directoryName)
    {
        
        $directory = null;
        Severity: Major
        Found in src/main/php/Gomoob/MetadataExtractor/Imaging/ImageMetadataReader.php - About 4 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              grunt.registerTask('before-pdepend' , 'Creating directories required by PDepend...', function() {

        if(!fs.existsSync('build')) {
            fs.mkdirSync('build');
        }
          Severity: Major
          Found in Gruntfile.js and 1 other location - About 3 hrs to fix
          Gruntfile.js on lines 209..223

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              grunt.registerTask('before-phpmd', 'Creating directories required by PHP Mess Detector...', function() {
       
        if(!fs.existsSync('build')) {
            fs.mkdirSync('build');
        }
          Severity: Major
          Found in Gruntfile.js and 1 other location - About 3 hrs to fix
          Gruntfile.js on lines 167..181

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File ExifDirectoryBase.php has 309 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php

/**
 * gomoob/php-metadata-extractor
*
          Severity: Minor
          Found in src/main/php/Gomoob/MetadataExtractor/Metadata/Exif/ExifDirectoryBase.php - About 3 hrs to fix

            Function readMetadata has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function readMetadata($file)
    {
        $metadata = new Metadata();
        
        $metadataExtractorDriver = MetadataExtractorDriver::create();
            Severity: Minor
            Found in src/main/php/Gomoob/MetadataExtractor/Imaging/ImageMetadataReader.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getSimplifiedInstance has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getSimplifiedInstance()
    {
        if ($this->tooComplexForSimplification()) {
            return $this;
        }
            Severity: Minor
            Found in src/main/php/Gomoob/MetadataExtractor/Lang/Rational.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function toSimpleString has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function toSimpleString($allowDecimal)
    {
        if ($this->denominator == 0 && $this->numerator != 0) {
            return $this->toString();
        } elseif ($this->isInteger()) {
            Severity: Minor
            Found in src/main/php/Gomoob/MetadataExtractor/Lang/Rational.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            <?php

/**
 * gomoob/php-metadata-extractor
 *
            Severity: Minor
            Found in src/main/php/Gomoob/MetadataExtractor/Metadata/Photoshop/DuckyDirectory.php and 1 other location - About 55 mins to fix
            src/main/php/Gomoob/MetadataExtractor/Metadata/File/FileMetadataDirectory.php on lines 1..50

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            <?php

/**
 * gomoob/php-metadata-extractor
 *
            Severity: Minor
            Found in src/main/php/Gomoob/MetadataExtractor/Metadata/File/FileMetadataDirectory.php and 1 other location - About 55 mins to fix
            src/main/php/Gomoob/MetadataExtractor/Metadata/Photoshop/DuckyDirectory.php on lines 1..51

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                command : function() {
                        
                        var command = 'php ./vendor/squizlabs/php_codesniffer/scripts/phpcbf';
                        command += ' --standard=PSR2';
                        command += ' --no-patch';
            Severity: Minor
            Found in Gruntfile.js and 1 other location - About 40 mins to fix
            Gruntfile.js on lines 135..145

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                command : function() {
                        
                        var command = 'php vendor/phpmd/phpmd/src/bin/phpmd ';
                        command += 'src/main/php ';
                        command += 'html ';
            Severity: Minor
            Found in Gruntfile.js and 1 other location - About 40 mins to fix
            Gruntfile.js on lines 98..109

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this method.
            Open

                            return sprintf("Unknown (%s)", $this->componentId);
            Severity: Major
            Found in src/main/php/Gomoob/MetadataExtractor/Metadata/Jpeg/JpegComponent.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $simplifiedInstance->toString();
              Severity: Major
              Found in src/main/php/Gomoob/MetadataExtractor/Lang/Rational.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return null;
                Severity: Major
                Found in src/main/php/Gomoob/MetadataExtractor/Metadata/Directory.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return 'Q';
                  Severity: Major
                  Found in src/main/php/Gomoob/MetadataExtractor/Metadata/Jpeg/JpegComponent.php - About 30 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language