Sign upLogin

gomoob/php-metadata-extractor

View on GitHub
Star

Showing 16 of 22 total issues

Function addTagToDirectory has a Cognitive Complexity of 213 (exceeds 5 allowed). Consider refactoring.
Open

    private static function addTagToDirectory(Directory $directory, $tagLine)
    {
        $start = strpos($tagLine, '] ');
        
        if ($start === false) {
Severity: Minor
Found in src/main/php/Gomoob/MetadataExtractor/Imaging/ImageMetadataReader.php - About 4 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addTagToDirectory has 478 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function addTagToDirectory(Directory $directory, $tagLine)
    {
        $start = strpos($tagLine, '] ');
        
        if ($start === false) {
Severity: Major
Found in src/main/php/Gomoob/MetadataExtractor/Imaging/ImageMetadataReader.php - About 2 days to fix

    File ImageMetadataReader.php has 703 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * gomoob/php-metadata-extractor
 *
    Severity: Major
    Found in src/main/php/Gomoob/MetadataExtractor/Imaging/ImageMetadataReader.php - About 1 day to fix

      Function createDirectoryWithName has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function createDirectoryWithName($directoryName)
    {
        
        $directory = null;
      Severity: Minor
      Found in src/main/php/Gomoob/MetadataExtractor/Imaging/ImageMetadataReader.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exports has 134 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(grunt) {

    grunt.initConfig(
        {
      Severity: Major
      Found in Gruntfile.js - About 5 hrs to fix

        Method createDirectoryWithName has 111 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private static function createDirectoryWithName($directoryName)
    {
        
        $directory = null;
        Severity: Major
        Found in src/main/php/Gomoob/MetadataExtractor/Imaging/ImageMetadataReader.php - About 4 hrs to fix

          File ExifDirectoryBase.php has 309 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php

/**
 * gomoob/php-metadata-extractor
*
          Severity: Minor
          Found in src/main/php/Gomoob/MetadataExtractor/Metadata/Exif/ExifDirectoryBase.php - About 3 hrs to fix

            Function readMetadata has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function readMetadata($file)
    {
        $metadata = new Metadata();
        
        $metadataExtractorDriver = MetadataExtractorDriver::create();
            Severity: Minor
            Found in src/main/php/Gomoob/MetadataExtractor/Imaging/ImageMetadataReader.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getSimplifiedInstance has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getSimplifiedInstance()
    {
        if ($this->tooComplexForSimplification()) {
            return $this;
        }
            Severity: Minor
            Found in src/main/php/Gomoob/MetadataExtractor/Lang/Rational.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function toSimpleString has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function toSimpleString($allowDecimal)
    {
        if ($this->denominator == 0 && $this->numerator != 0) {
            return $this->toString();
        } elseif ($this->isInteger()) {
            Severity: Minor
            Found in src/main/php/Gomoob/MetadataExtractor/Lang/Rational.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                            return sprintf("Unknown (%s)", $this->componentId);
            Severity: Major
            Found in src/main/php/Gomoob/MetadataExtractor/Metadata/Jpeg/JpegComponent.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $simplifiedInstance->toString();
              Severity: Major
              Found in src/main/php/Gomoob/MetadataExtractor/Lang/Rational.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return null;
                Severity: Major
                Found in src/main/php/Gomoob/MetadataExtractor/Metadata/Directory.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return 'Q';
                  Severity: Major
                  Found in src/main/php/Gomoob/MetadataExtractor/Metadata/Jpeg/JpegComponent.php - About 30 mins to fix

                    Function getInteger has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function getInteger($tagType)
    {
        // FIXME: This method has to be reviewed

        $o = $this->getObject($tagType);
                    Severity: Minor
                    Found in src/main/php/Gomoob/MetadataExtractor/Metadata/Directory.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function __construct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function __construct($identifierOrBytes, $multipleAllowed = null)
    {
        if (is_string($identifierOrBytes)) {
            $this->multipleAllowed = $multipleAllowed;
            try {
                    Severity: Minor
                    Found in src/main/php/Gomoob/MetadataExtractor/Imaging/Png/PngChunkType.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language