Sign upLogin

gomoob/php-pushwoosh

View on GitHub
Star

Showing 27 of 27 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

/**
 * gomoob/php-pushwoosh
 *
Severity: Major
Found in src/main/php/Gomoob/Pushwoosh/Model/Notification/Chrome.php and 2 other locations - About 1 day to fix
src/main/php/Gomoob/Pushwoosh/Model/Notification/Mac.php on lines 1..100
src/main/php/Gomoob/Pushwoosh/Model/Notification/Safari.php on lines 1..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 274.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

/**
 * gomoob/php-pushwoosh
 *
Severity: Major
Found in src/main/php/Gomoob/Pushwoosh/Model/Notification/Safari.php and 2 other locations - About 1 day to fix
src/main/php/Gomoob/Pushwoosh/Model/Notification/Chrome.php on lines 1..167
src/main/php/Gomoob/Pushwoosh/Model/Notification/Mac.php on lines 1..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 274.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

/**
 * gomoob/php-pushwoosh
 *
Severity: Major
Found in src/main/php/Gomoob/Pushwoosh/Model/Notification/Mac.php and 2 other locations - About 1 day to fix
src/main/php/Gomoob/Pushwoosh/Model/Notification/Chrome.php on lines 1..167
src/main/php/Gomoob/Pushwoosh/Model/Notification/Safari.php on lines 1..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 274.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Notification has 59 functions (exceeds 20 allowed). Consider refactoring.
Open

class Notification implements \JsonSerializable
{
    /**
     * An object which contains specific Pushwoosh notification informations for ADM (Amazon Device Messaging).
     *
Severity: Major
Found in src/main/php/Gomoob/Pushwoosh/Model/Notification/Notification.php - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php

/**
 * gomoob/php-pushwoosh
 *
    Severity: Major
    Found in src/main/php/Gomoob/Pushwoosh/Model/Request/PushStatRequest.php and 1 other location - About 7 hrs to fix
    src/main/php/Gomoob/Pushwoosh/Model/Request/SetBadgeRequest.php on lines 1..155

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 225.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php

/**
 * gomoob/php-pushwoosh
 *
    Severity: Major
    Found in src/main/php/Gomoob/Pushwoosh/Model/Request/SetBadgeRequest.php and 1 other location - About 7 hrs to fix
    src/main/php/Gomoob/Pushwoosh/Model/Request/PushStatRequest.php on lines 1..157

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 225.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function exports has 148 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(grunt) {

    grunt.initConfig(
        {
    Severity: Major
    Found in Gruntfile.js - About 5 hrs to fix

      File Notification.php has 359 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

/**
 * gomoob/php-pushwoosh
 *
      Severity: Minor
      Found in src/main/php/Gomoob/Pushwoosh/Model/Notification/Notification.php - About 4 hrs to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        <?php

/**
 * gomoob/php-pushwoosh
 *
        Severity: Major
        Found in src/main/php/Gomoob/Pushwoosh/Model/Response/GetTagsResponse.php and 2 other locations - About 4 hrs to fix
        src/main/php/Gomoob/Pushwoosh/Model/Response/CreateMessageResponse.php on lines 1..74
        src/main/php/Gomoob/Pushwoosh/Model/Response/CreateTargetedMessageResponse.php on lines 1..74

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 175.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        <?php

/**
 * gomoob/php-pushwoosh
 *
        Severity: Major
        Found in src/main/php/Gomoob/Pushwoosh/Model/Response/CreateTargetedMessageResponse.php and 2 other locations - About 4 hrs to fix
        src/main/php/Gomoob/Pushwoosh/Model/Response/CreateMessageResponse.php on lines 1..74
        src/main/php/Gomoob/Pushwoosh/Model/Response/GetTagsResponse.php on lines 1..74

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 175.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        <?php

/**
 * gomoob/php-pushwoosh
 *
        Severity: Major
        Found in src/main/php/Gomoob/Pushwoosh/Model/Response/CreateMessageResponse.php and 2 other locations - About 4 hrs to fix
        src/main/php/Gomoob/Pushwoosh/Model/Response/CreateTargetedMessageResponse.php on lines 1..74
        src/main/php/Gomoob/Pushwoosh/Model/Response/GetTagsResponse.php on lines 1..74

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 175.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        CreateTargetedMessageRequest has 31 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class CreateTargetedMessageRequest extends AbstractRequest
{
    /**
     * The campaign code to which you want to assign this push message.
     *
        Severity: Minor
        Found in src/main/php/Gomoob/Pushwoosh/Model/Request/CreateTargetedMessageRequest.php - About 3 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              grunt.registerTask('before-phpmd', 'Creating directories required by PHP Mess Detector...', function() {

        if(!fs.existsSync('build')) {
            fs.mkdirSync('build');
        }
          Severity: Major
          Found in Gruntfile.js and 1 other location - About 3 hrs to fix
          Gruntfile.js on lines 176..190

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              grunt.registerTask('before-pdepend' , 'Creating directories required by PDepend...', function() {

        if(!fs.existsSync('build')) {
            fs.mkdirSync('build');
        }
          Severity: Major
          Found in Gruntfile.js and 1 other location - About 3 hrs to fix
          Gruntfile.js on lines 218..232

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Android has 26 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class Android implements \JsonSerializable
{
    /**
     * Android application icon badge number.
     *
          Severity: Minor
          Found in src/main/php/Gomoob/Pushwoosh/Model/Notification/Android.php - About 3 hrs to fix

            Pushwoosh has 22 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class Pushwoosh implements IPushwoosh // NOSONAR
{
    /**
     * The the Pushwoosh application ID to be used by default by all the requests performed by the Pushwoosh client.
     * This identifier can be overwritten by request if needed.
            Severity: Minor
            Found in src/main/php/Gomoob/Pushwoosh/Client/Pushwoosh.php - About 2 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function setSendDate(/* \DateTime */ $sendDate)
    {
        // Try to parse a string date
        if (is_string($sendDate) && $sendDate !== 'now') {
            $newSendDate = \DateTime::createFromFormat('Y-m-d H:i', $sendDate);
              Severity: Major
              Found in src/main/php/Gomoob/Pushwoosh/Model/Notification/Notification.php and 1 other location - About 1 hr to fix
              src/main/php/Gomoob/Pushwoosh/Model/Request/CreateTargetedMessageRequest.php on lines 522..545

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 120.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function setSendDate(/* \DateTime */ $sendDate)
    {
        // Try to parse a string date
        if (is_string($sendDate) && $sendDate !== 'now') {
            $newSendDate = \DateTime::createFromFormat('Y-m-d H:i', $sendDate);
              Severity: Major
              Found in src/main/php/Gomoob/Pushwoosh/Model/Request/CreateTargetedMessageRequest.php and 1 other location - About 1 hr to fix
              src/main/php/Gomoob/Pushwoosh/Model/Notification/Notification.php on lines 1081..1104

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 120.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method jsonSerialize has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function jsonSerialize()
    {
        $json = [];
    
        // Mandatory parameters
              Severity: Minor
              Found in src/main/php/Gomoob/Pushwoosh/Model/Notification/Notification.php - About 1 hr to fix

                Function checkDeviceType has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function checkDeviceType()
    {
        // The 'deviceType' parameter must have been defined.
        if (!isset($this->deviceType)) {
            throw new PushwooshException('The \'deviceType\' property is not set !');
                Severity: Minor
                Found in src/main/php/Gomoob/Pushwoosh/Model/Request/RegisterDeviceRequest.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language