Sign upLogin

gomoob/php-value-filter-dsl

View on GitHub
Star

Showing 10 of 10 total issues

Function parseFromFirstToken has a Cognitive Complexity of 85 (exceeds 5 allowed). Consider refactoring.
Open

    private function parseFromFirstToken(
        /* string */ $key,
        /* string */ $value,
        /* array */ $tokens,
        /* boolean */ $afterNot
Severity: Minor
Found in src/main/php/Gomoob/Filter/Sql/SqlFilterConverter.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parseFromFirstToken has 249 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function parseFromFirstToken(
        /* string */ $key,
        /* string */ $value,
        /* array */ $tokens,
        /* boolean */ $afterNot
Severity: Major
Found in src/main/php/Gomoob/Filter/Sql/SqlFilterConverter.php - About 1 day to fix

    Function exports has 150 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(grunt) {

    grunt.initConfig(
        {
    Severity: Major
    Found in Gruntfile.js - About 6 hrs to fix

      File SqlFilterConverter.php has 371 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

/**
 * BSD 3-Clause License
 *
      Severity: Minor
      Found in src/main/php/Gomoob/Filter/Sql/SqlFilterConverter.php - About 4 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            grunt.registerTask('before-phpmd', 'Creating directories required by PHP Mess Detector...', function() {

        if(!fs.existsSync('build')) {
            fs.mkdirSync('build');
        }
        Severity: Major
        Found in Gruntfile.js and 1 other location - About 3 hrs to fix
        Gruntfile.js on lines 178..192

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            grunt.registerTask('before-pdepend' , 'Creating directories required by PDepend...', function() {

        if(!fs.existsSync('build')) {
            fs.mkdirSync('build');
        }
        Severity: Major
        Found in Gruntfile.js and 1 other location - About 3 hrs to fix
        Gruntfile.js on lines 220..234

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function tokenize has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public function tokenize(/* string */ $string) /* : array */
    {
        $tokens = [];

        // First we clean our string
        Severity: Minor
        Found in src/main/php/Gomoob/Filter/Tokenizer/AbstractTokenizer.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method tokenize has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function tokenize(/* string */ $string) /* : array */
    {
        $tokens = [];

        // First we clean our string
        Severity: Minor
        Found in src/main/php/Gomoob/Filter/Tokenizer/AbstractTokenizer.php - About 1 hr to fix

          Function transformComplexFilter has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              private function transformComplexFilter(
        /* string */ $key,
        /* string */ $value,
        /* array */ $context
    ) /* : array */ {
          Severity: Minor
          Found in src/main/php/Gomoob/Filter/Sql/SqlFilterConverter.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function convertSimpleOperatorTokenToSqlString has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function convertSimpleOperatorTokenToSqlString(/* TokenInterface */ $token) /* : string */
    {
        $sqlString = '';

        switch ($token->getTokenCode()) {
          Severity: Minor
          Found in src/main/php/Gomoob/Filter/Sql/SqlFilterConverter.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language