Sign upLogin

gooddata/gooddata-ruby

View on GitHub
Star
lib/gooddata/lcm/actions/update_metric_formats.rb

Summary

Maintainability
D
1 day
Test Coverage

Method validate_input_source has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

        def validate_input_source(input_source, continue_on_error)
          type = input_source[:type] if input_source&.dig(:type)
          metric_format = input_source[:metric_format]
          if type.blank?
            raise "Incorrect configuration: 'type' of 'input_source' is required" unless continue_on_error
Severity: Minor
Found in lib/gooddata/lcm/actions/update_metric_formats.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_input_source has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def validate_input_source(input_source, continue_on_error)
          type = input_source[:type] if input_source&.dig(:type)
          metric_format = input_source[:metric_format]
          if type.blank?
            raise "Incorrect configuration: 'type' of 'input_source' is required" unless continue_on_error
Severity: Minor
Found in lib/gooddata/lcm/actions/update_metric_formats.rb - About 2 hrs to fix

    Method call has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

            def call(params)
          data = load_metric_data(params)
          result = []
          return result if data.nil?
    Severity: Minor
    Found in lib/gooddata/lcm/actions/update_metric_formats.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method call has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def call(params)
          data = load_metric_data(params)
          result = []
          return result if data.nil?
    Severity: Minor
    Found in lib/gooddata/lcm/actions/update_metric_formats.rb - About 1 hr to fix

      Method load_metric_data has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

              def load_metric_data(params)
          collect_synced_status = collect_synced_status(params)

          if params&.dig(:input_source, :metric_format) && params[:input_source][:metric_format].present?
            metric_input_source = validate_input_source(params[:input_source], collect_synced_status)
      Severity: Minor
      Found in lib/gooddata/lcm/actions/update_metric_formats.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                    return nil
      Severity: Major
      Found in lib/gooddata/lcm/actions/update_metric_formats.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return nil
        Severity: Major
        Found in lib/gooddata/lcm/actions/update_metric_formats.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return modified_input_source
          Severity: Major
          Found in lib/gooddata/lcm/actions/update_metric_formats.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return modified_input_source
            Severity: Major
            Found in lib/gooddata/lcm/actions/update_metric_formats.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                            return nil
              Severity: Major
              Found in lib/gooddata/lcm/actions/update_metric_formats.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return modified_input_source
                Severity: Major
                Found in lib/gooddata/lcm/actions/update_metric_formats.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return modified_input_source
                  Severity: Major
                  Found in lib/gooddata/lcm/actions/update_metric_formats.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                  return nil
                    Severity: Major
                    Found in lib/gooddata/lcm/actions/update_metric_formats.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return nil
                      Severity: Major
                      Found in lib/gooddata/lcm/actions/update_metric_formats.rb - About 30 mins to fix

                        Method get_clients_metrics has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                                def get_clients_metrics(metric_data)
          return {} if metric_data.nil?

          metric_groups = {}
          clients = metric_data.map { |row| row[:client_id] }.uniq
                        Severity: Minor
                        Found in lib/gooddata/lcm/actions/update_metric_formats.rb - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                  when 'web'
            if metric_format[:url].blank?
              GoodData.logger.warn("The metric input_source '#{type}' is missing property 'url'")
              return nil
            end
                        Severity: Minor
                        Found in lib/gooddata/lcm/actions/update_metric_formats.rb and 2 other locations - About 15 mins to fix
                        lib/gooddata/lcm/actions/update_metric_formats.rb on lines 114..121
                        lib/gooddata/lcm/actions/update_metric_formats.rb on lines 122..129

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 26.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                  when 'blobStorage'
            if metric_format[:file].blank?
              GoodData.logger.warn("The metric input_source '#{type}' is missing property 'file'")
              return nil
            end
                        Severity: Minor
                        Found in lib/gooddata/lcm/actions/update_metric_formats.rb and 2 other locations - About 15 mins to fix
                        lib/gooddata/lcm/actions/update_metric_formats.rb on lines 122..129
                        lib/gooddata/lcm/actions/update_metric_formats.rb on lines 130..137

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 26.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                  when 'staging'
            if metric_format[:file].blank?
              GoodData.logger.warn("The metric input_source '#{type}' is missing property 'file'")
              return nil
            end
                        Severity: Minor
                        Found in lib/gooddata/lcm/actions/update_metric_formats.rb and 2 other locations - About 15 mins to fix
                        lib/gooddata/lcm/actions/update_metric_formats.rb on lines 114..121
                        lib/gooddata/lcm/actions/update_metric_formats.rb on lines 130..137

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 26.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status