Sign upLogin

google/chromeos-filesystems

View on GitHub
Star

Showing 78 of 78 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

chrome.app.runtime.onLaunched.addListener(function() {
  // Open the settings UI when the user clicks on the app icon in the Chrome
  // app launcher.

  var windowOptions = {
Severity: Major
Found in webdavfs/js/main.js and 1 other location - About 1 hr to fix
s3fs/js/main.js on lines 82..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    default:
      var message;
      if (request.type) {
        message = 'Invalid request type: ' + request.type + '.';
      } else {
Severity: Major
Found in s3fs/js/main.js and 2 other locations - About 1 hr to fix
templatefs/js/main.js on lines 26..39
webdavfs/js/main.js on lines 80..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    default:
      var message;
      if (request.type) {
        message = 'Invalid request type: ' + request.type + '.';
      } else {
Severity: Major
Found in templatefs/js/main.js and 2 other locations - About 1 hr to fix
s3fs/js/main.js on lines 124..137
webdavfs/js/main.js on lines 80..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    default:
      var message;
      if (request.type) {
        message = 'Invalid request type: ' + request.type + '.';
      } else {
Severity: Major
Found in webdavfs/js/main.js and 2 other locations - About 1 hr to fix
s3fs/js/main.js on lines 124..137
templatefs/js/main.js on lines 26..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

WebDAVFS.prototype.copyEntry = function(options) {
  client.copy(this.url + options.sourcePath, this.url + options.targetPath,
    options.onSuccess, options.onError);
};
Severity: Major
Found in webdavfs/js/wdfs.js and 1 other location - About 1 hr to fix
webdavfs/js/wdfs.js on lines 152..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

WebDAVFS.prototype.moveEntry = function(options) {
  client.move(this.url + options.sourcePath, this.url + options.targetPath,
    options.onSuccess, options.onError);
};
Severity: Major
Found in webdavfs/js/wdfs.js and 1 other location - About 1 hr to fix
webdavfs/js/wdfs.js on lines 137..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function request has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

WebDAVClient.prototype.request = function(verb, url, headers, data, responseType,
  onSuccess, onError) {
    var xhr = new XMLHttpRequest();

    var processBody = function() {
Severity: Minor
Found in webdavfs/js/client.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(onGetMetadataRequested) {
  describe('onGetMetadataRequested', function() {
    it('should return the correct metadata object for files', function(done) {
      var options = {
        entryPath: '/1.txt'
Severity: Minor
Found in shared_tests/onGetMetadataRequested.js - About 1 hr to fix

    Function exports has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(fs, onCloseFileRequested, onOpenFileRequested) {
  describe('onCloseFileRequested', function() {
    it('should reject attempts to close unopened files', function(done) {
      var options = {
        openRequestId: 123
    Severity: Minor
    Found in shared_tests/onCloseFileRequested.js - About 1 hr to fix

      Function onDeleteEntryRequested has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var onDeleteEntryRequested = function(options, onSuccess, onError) {
  if (!options.entryPath) {
    onError('INVALID_OPERATION');
    return;
  }
      Severity: Minor
      Found in webdavfs/js/events.js - About 1 hr to fix

        Function testFactory has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        var testFactory = function(open, read, truncate) {
  return function(file, id, length, expected) {
    return function(done) {
      var openOptions = {
        filePath: file,
        Severity: Minor
        Found in shared_tests/onTruncateRequested.js - About 1 hr to fix

          Function exports has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function(onReadDirectoryRequested) {
  describe('onReadDirectoryRequested', function() {
    it('should return the correct contents for the given directory',
      function(done) {
        var options = {
          Severity: Minor
          Found in shared_tests/onReadDirectoryRequested.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  mount(request.url, {
        onSuccess: function() {
          sendResponse({
            type: 'mount',
            success: true
            Severity: Major
            Found in webdavfs/js/main.js and 1 other location - About 1 hr to fix
            s3fs/js/main.js on lines 108..122

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  mount(request.bucket, request.region, request.access, request.secret, {
        onSuccess: function() {
          sendResponse({
            type: 'mount',
            success: true
            Severity: Major
            Found in s3fs/js/main.js and 1 other location - About 1 hr to fix
            webdavfs/js/main.js on lines 64..78

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function onGetMetadataRequested has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            var onGetMetadataRequested = function(options, onSuccess, onError) {
  // Remove the leading slash from the path -- this isn't used in S3 keys.
  var path = options.entryPath.substring(1);

  var metadata;
            Severity: Minor
            Found in s3fs/js/events.js - About 1 hr to fix

              Function onTruncateRequested has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              var onTruncateRequested = function(options, onSuccess, onError) {
  // Strip the leading slash, since not used internally.
  var path = options.filePath.substring(1);

  var readParameters = s3fs.parameters({
              Severity: Minor
              Found in s3fs/js/events.js - About 1 hr to fix

                Function request has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                WebDAVClient.prototype.request = function(verb, url, headers, data, responseType,
  onSuccess, onError) {
    var xhr = new XMLHttpRequest();

    var processBody = function() {
                Severity: Minor
                Found in webdavfs/js/client.js - About 1 hr to fix

                  Function onDeleteEntryRequested has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                  var onDeleteEntryRequested = function(options, onSuccess, onError) {
  if (!options.entryPath) {
    onError('INVALID_OPERATION');
    return;
  }
                  Severity: Minor
                  Found in webdavfs/js/events.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function onTruncateRequested has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  var onTruncateRequested = function(options, onSuccess, onError) {
  if (!options.filePath) {
    onError('INVALID_OPERATION');
    return;
  }
                  Severity: Minor
                  Found in webdavfs/js/events.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                      if (!s3fs.openedFiles[options.openRequestId]) {
    onError('INVALID_OPERATION');
  } else {
    delete s3fs.openedFiles[options.openRequestId];
    onSuccess();
                    Severity: Major
                    Found in s3fs/js/events.js and 1 other location - About 1 hr to fix
                    webdavfs/js/events.js on lines 25..30

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 55.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language