Sign upLogin

gosddc/vagrant-vcloudair

View on GitHub
Star
lib/vagrant-vcloudair/driver/base.rb

Summary

Maintainability
F
3 days
Test Coverage

Class Base has 40 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Base
        include Vagrant::Util::Retryable

        def initialize
          @logger = Log4r::Logger.new('vagrant::provider::vcloudair::base')
Severity: Minor
Found in lib/vagrant-vcloudair/driver/base.rb - About 5 hrs to fix

File base.rb has 346 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'log4r'
require 'vagrant/util/busy'
require 'vagrant/util/platform'
require 'vagrant/util/retryable'
require 'vagrant/util/subprocess'
Severity: Minor
Found in lib/vagrant-vcloudair/driver/base.rb - About 4 hrs to fix

Method upload_file has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def upload_file(upload_url, upload_file, vapp_template, config = {})
          # Set chunksize to 5M if not specified otherwise
          chunk_size = (config[:chunksize] || 5_242_880)
          @logger.debug("Set chunksize to #{chunk_size} bytes")
Severity: Major
Found in lib/vagrant-vcloudair/driver/base.rb - About 3 hrs to fix

Method upload_file has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        def upload_file(upload_url, upload_file, vapp_template, config = {})
          # Set chunksize to 5M if not specified otherwise
          chunk_size = (config[:chunksize] || 5_242_880)
          @logger.debug("Set chunksize to #{chunk_size} bytes")
Severity: Minor
Found in lib/vagrant-vcloudair/driver/base.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method send_vcloudair_request has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

          def send_vcloudair_request(params, payload = nil, content_type = nil)
            # Create a new HTTP client
            clnt = HTTPClient.new

            # Disable SSL cert verification
Severity: Major
Found in lib/vagrant-vcloudair/driver/base.rb - About 2 hrs to fix

Method send_request has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def send_request(params, payload = nil, content_type = nil)
          # Create a new HTTP client
          clnt = HTTPClient.new

          # Set SSL proto to TLSv1
Severity: Major
Found in lib/vagrant-vcloudair/driver/base.rb - About 2 hrs to fix

Method send_vcloudair_request has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

          def send_vcloudair_request(params, payload = nil, content_type = nil)
            # Create a new HTTP client
            clnt = HTTPClient.new

            # Disable SSL cert verification
Severity: Minor
Found in lib/vagrant-vcloudair/driver/base.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method send_request has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

        def send_request(params, payload = nil, content_type = nil)
          # Create a new HTTP client
          clnt = HTTPClient.new

          # Set SSL proto to TLSv1
Severity: Minor
Found in lib/vagrant-vcloudair/driver/base.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method upload_ovf has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def upload_ovf(vdc_id, vapp_name, vapp_description, ovf_file,
                       catalog_id, upload_options = {})
Severity: Minor
Found in lib/vagrant-vcloudair/driver/base.rb - About 45 mins to fix

Method create_vapp_from_template has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def create_vapp_from_template(vdc, vapp_name, vapp_description,
                                      vapp_templateid, poweron = false)
Severity: Minor
Found in lib/vagrant-vcloudair/driver/base.rb - About 35 mins to fix

Method compose_vapp_from_vm has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def compose_vapp_from_vm(vdc, vapp_name, vapp_description,
                                 vm_list = {}, network_config = {})
Severity: Minor
Found in lib/vagrant-vcloudair/driver/base.rb - About 35 mins to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

              if @logger.level == 1
                ap "[#{Time.now.ctime}] <- RECV #{response.status}"
                # Just avoid the task spam.
                unless url.index('/task/')
                  ap 'RECV HEADERS'
Severity: Minor
Found in lib/vagrant-vcloudair/driver/base.rb and 1 other location - About 25 mins to fix
lib/vagrant-vcloudair/driver/base.rb on lines 485..492

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            if @logger.level == 1
              ap "[#{Time.now.ctime}] <- RECV #{response.status}"
              # Just avoid the task spam.
              unless url.index('/task/')
                ap 'RECV HEADERS'
Severity: Minor
Found in lib/vagrant-vcloudair/driver/base.rb and 1 other location - About 25 mins to fix
lib/vagrant-vcloudair/driver/base.rb on lines 361..368

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status