Sign upLogin

govau/performance-dashboard

View on GitHub
Star
app/controllers/api/v1/dashboards_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Method create_full has 178 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create_full
    dashboard = Dashboard.new dashboard_params
    dashboard.notes = params[:notes].as_json
    dashboard.published_at = Time.now
    dashboard.save!
Severity: Major
Found in app/controllers/api/v1/dashboards_controller.rb - About 7 hrs to fix

    Method create_full has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def create_full
    dashboard = Dashboard.new dashboard_params
    dashboard.notes = params[:notes].as_json
    dashboard.published_at = Time.now
    dashboard.save!
    Severity: Minor
    Found in app/controllers/api/v1/dashboards_controller.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          :data => {
        :values => {
          dataset1.id => params[:userSatisfaction].empty? ? nil : params[:userSatisfaction],
          dataset2.id => params[:costPerTransaction].empty? ? nil : params[:costPerTransaction],
          dataset3.id => params[:digitalTakeup].empty? ? nil : params[:digitalTakeup],
    Severity: Minor
    Found in app/controllers/api/v1/dashboards_controller.rb and 1 other location - About 1 hr to fix
    app/controllers/api/v1/widgets_controller.rb on lines 213..219

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        widget2 = Widget.create({
      :dashboard_id => dashboard.id,
      :data_table_id => data_table.id,
      :name => 'Cost per transaction',
      :options => {},
    Severity: Minor
    Found in app/controllers/api/v1/dashboards_controller.rb and 3 other locations - About 15 mins to fix
    app/controllers/api/v1/dashboards_controller.rb on lines 48..58
    app/controllers/api/v1/dashboards_controller.rb on lines 74..84
    app/controllers/api/v1/dashboards_controller.rb on lines 87..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        widget4 = Widget.create({
      :dashboard_id => dashboard.id,
      :data_table_id => data_table.id,
      :name => 'Completion rate',
      :options => {},
    Severity: Minor
    Found in app/controllers/api/v1/dashboards_controller.rb and 3 other locations - About 15 mins to fix
    app/controllers/api/v1/dashboards_controller.rb on lines 48..58
    app/controllers/api/v1/dashboards_controller.rb on lines 61..71
    app/controllers/api/v1/dashboards_controller.rb on lines 74..84

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        widget1 = Widget.create({
      :dashboard_id => dashboard.id,
      :data_table_id => data_table.id,
      :name => 'User satisfaction',
      :options => {},
    Severity: Minor
    Found in app/controllers/api/v1/dashboards_controller.rb and 3 other locations - About 15 mins to fix
    app/controllers/api/v1/dashboards_controller.rb on lines 61..71
    app/controllers/api/v1/dashboards_controller.rb on lines 74..84
    app/controllers/api/v1/dashboards_controller.rb on lines 87..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        widget3 = Widget.create({
      :dashboard_id => dashboard.id,
      :data_table_id => data_table.id,
      :name => 'Digital take-up',
      :options => {},
    Severity: Minor
    Found in app/controllers/api/v1/dashboards_controller.rb and 3 other locations - About 15 mins to fix
    app/controllers/api/v1/dashboards_controller.rb on lines 48..58
    app/controllers/api/v1/dashboards_controller.rb on lines 61..71
    app/controllers/api/v1/dashboards_controller.rb on lines 87..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status