Sign upLogin

goyalmunish/request_response_stats

View on GitHub
Star
lib/request_response_stats/req_res_stat.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method get_details has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def get_details(key, start_time, end_time, stat_type = nil, granularity = DEFAULT_STATS_GRANULARITY)
      # get ungrouped data
      stat_type = stat_type.to_s.to_sym if stat_type
      key = key.to_s.to_sym
      relevant_records = get_within(start_time, end_time)
Severity: Minor
Found in lib/request_response_stats/req_res_stat.rb - About 1 hr to fix

    Method get_details has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_details(key, start_time, end_time, stat_type = nil, granularity = DEFAULT_STATS_GRANULARITY)
      # get ungrouped data
      stat_type = stat_type.to_s.to_sym if stat_type
      key = key.to_s.to_sym
      relevant_records = get_within(start_time, end_time)
    Severity: Minor
    Found in lib/request_response_stats/req_res_stat.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_stat has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def get_stat(stat_type, key, start_time, end_time, granularity = DEFAULT_STATS_GRANULARITY)
    Severity: Minor
    Found in lib/request_response_stats/req_res_stat.rb - About 35 mins to fix

      Method get_details has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def get_details(key, start_time, end_time, stat_type = nil, granularity = DEFAULT_STATS_GRANULARITY)
      Severity: Minor
      Found in lib/request_response_stats/req_res_stat.rb - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status