Sign upLogin

grafana/grafana-polystat-panel

View on GitHub
Star

Showing 96 of 189 total issues

Function getMappedValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export function getMappedValue(valueMappings: LegacyValueMapping[], value: any): LegacyValueMapping {
  // intentional use of deprecated function for v8 compat
  // eslint-disable-next-line deprecation/deprecation
  const emptyResult = { type: LegacyMappingType.ValueToText, value: '', text: '', from: '', to: '', id: 0 };
  if (!valueMappings?.length) {
Severity: Minor
Found in src/data/valueMappingsWrapper/v8/valueMappings.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addRangeToTextMappingText has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

const addRangeToTextMappingText = (
  allValueMappings: ValueMapping[],
  rangeToTextMapping: RangeMap,
  value: TimeSeriesValue
) => {
Severity: Minor
Found in src/data/valueMappingsWrapper/v7/valueMappings.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

  return null;
Severity: Major
Found in src/data/valueMappingsWrapper/v8/valueMappings.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      return allValueMappings.concat(valueToTextMapping);
    Severity: Major
    Found in src/data/valueMappingsWrapper/v7/valueMappings.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                    return vm.options.result;
      Severity: Major
      Found in src/data/valueMappingsWrapper/v8/valueMappings.ts - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        test('check grafana license status', async ({ page }) => {
  await expect(page.locator('id=license')).toHaveText('Open Source');
});
        Severity: Minor
        Found in playwright/pre-auth/release/check-release.spec.ts and 1 other location - About 30 mins to fix
        playwright/pre-auth/release/check-release.spec.ts on lines 11..13

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

                      return vm.options.result;
        Severity: Major
        Found in src/data/valueMappingsWrapper/v8/valueMappings.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return { thresholdLevel: currentState, color: currentColor };
          Severity: Major
          Found in src/data/threshold_processor.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                          return vm.options.result;
            Severity: Major
            Found in src/data/valueMappingsWrapper/v8/valueMappings.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                            return vm.options.result;
              Severity: Major
              Found in src/data/valueMappingsWrapper/v8/valueMappings.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  return allValueMappings;
                Severity: Major
                Found in src/data/valueMappingsWrapper/v7/valueMappings.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                return vm.options.result;
                  Severity: Major
                  Found in src/data/valueMappingsWrapper/v8/valueMappings.ts - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    test('check grafana enterprise version with commit hash', async ({ page }) => {
  await expect(page.locator('id=version')).toHaveText('v10.3.3 (252761264e22ece57204b327f9130d3b44592c01)');
});
                    Severity: Minor
                    Found in playwright/pre-auth/release/check-release.spec.ts and 1 other location - About 30 mins to fix
                    playwright/pre-auth/release/check-release.spec.ts on lines 7..9

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function getWorstSeries has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function getWorstSeries(series1: PolystatModel, series2: PolystatModel): any {
  let worstSeries = series1;
  const series1ThresholdLevel = series1.thresholdLevel;
  const series2ThresholdLevel = series2.thresholdLevel;
                    Severity: Minor
                    Found in src/data/threshold_processor.ts - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getTextSizeForWidthAndHeight has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function getTextSizeForWidthAndHeight(
  text: string,
  font: any,
  width: number,
  height: number,
                    Severity: Minor
                    Found in src/utils.ts - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getActiveThreshold has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function getActiveThreshold(value: number, thresholds: Threshold[] | undefined): Threshold {
  if (!thresholds || thresholds.length === 0) {
    return fallBackThreshold;
  }
                    Severity: Minor
                    Found in src/data/valueMappingsWrapper/v8/thresholds.ts - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language