Sign upLogin

grafana/grafana-polystat-panel

View on GitHub
Star
src/components/metric_hints.ts

Summary

Maintainability
A
1 hr
Test Coverage

Function getMetricHints has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Wontfix

export const getMetricHints = (frames: any) => {
  let metricHints = new Set<string>();
  for (let i = 0; i < frames.length; i++) {
    // start with empty hint
    let hintValue = '';
Severity: Minor
Found in src/components/metric_hints.ts - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

          for (const aLabel in aField.labels) {
            if (aLabel !== '__name__') {
              appendLabels.push(`${aLabel}="${aField.labels[aLabel]}"`);
            }
          }
Severity: Major
Found in src/components/metric_hints.ts - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

              if (appendLabels.length > 0) {
            // sort them first
            appendLabels.sort();
            hintValue += '{' + appendLabels.join('') + '}';
          }
    Severity: Major
    Found in src/components/metric_hints.ts - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status