Sign upLogin

grafana/grafana-polystat-panel

View on GitHub
Star
src/data/composite_processor.ts

Summary

Maintainability
A
1 hr
Test Coverage

Function ApplyComposites has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
Wontfix

export const ApplyComposites = (
  composites: CompositeItemType[],
  data: PolystatModel[],
  replaceVariables: InterpolateFunction,
  compositesGlobalAliasingEnabled: boolean,
Severity: Minor
Found in src/data/composite_processor.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Wontfix

          if (aComposite.showTimestampEnabled) {
            seriesItem.timestampFormatted = TimeFormatter(timeZone, data[index].timestamp, aComposite.showTimestampFormat);
            seriesItem.showTimestamp = true;
          }
Severity: Major
Found in src/data/composite_processor.ts - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

              if (!aComposite.showMembers) {
            filteredMetrics.push(index);
          } else {
            keepMetrics.push(index);
          }
    Severity: Major
    Found in src/data/composite_processor.ts - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Wontfix

                if (aComposite.clickThrough && aComposite.clickThrough.length > 0) {
            let url = aComposite.clickThrough;
            // apply both types of transforms, one targeted at the data item index, and secondly the nth variant
            url = ClickThroughTransformer.transformComposite(aComposite.name, url);
            url = ClickThroughTransformer.transformSingleMetric(index, url, data);
      Severity: Major
      Found in src/data/composite_processor.ts - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                  if (aMetric.alias && aMetric.alias.length > 0) {
            seriesItem.displayName = resolveMemberAliasTemplates(aMetric.alias, matches);
          }
        Severity: Major
        Found in src/data/composite_processor.ts - About 45 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Wontfix

          export const customFormatter = (value: any) => {
  if (Object.prototype.toString.call(value) === '[object Array]') {
    return value.join(CUSTOM_SPLIT_DELIMITER);
  }
  return value;
          Severity: Minor
          Found in src/data/composite_processor.ts and 1 other location - About 30 mins to fix
          src/data/override_processor.ts on lines 23..28

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status